-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-8506] - Misplaced errorGroup
prop causing console error
#11398
Merged
pmakode-akamai
merged 2 commits into
linode:develop
from
pmakode-akamai:M3-8506-fix-misplaced-error-group-prop-console-error
Dec 12, 2024
Merged
fix: [M3-8506] - Misplaced errorGroup
prop causing console error
#11398
pmakode-akamai
merged 2 commits into
linode:develop
from
pmakode-akamai:M3-8506-fix-misplaced-error-group-prop-console-error
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… NodeBalancerConfigPanel
pmakode-akamai
requested review from
abailly-akamai and
harsh-akamai
and removed request for
a team
December 11, 2024 11:42
pmakode-akamai
changed the title
fix: [M3-8506] - Fix misplaced
fix: [M3-8506] - Misplaced Dec 11, 2024
errorGroup
prop causing console errorerrorGroup
prop causing console error
Cloud Manager UI test results🎉 469 passing tests on test run #3 ↗︎
|
jaalah-akamai
approved these changes
Dec 11, 2024
abailly-akamai
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch, thx for the fix 👍
mjac0bs
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Dec 11, 2024
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
A small, quick PR to fix the misplaced
errorGroup
prop that was causing a console error.Note: We will fix the other unrelated console errors in a follow-up PR
Changes 🔄
errorGroup
in textFieldPropsTarget release date 🗓️
N/A
Preview 📷
errorGroup
propHow to test 🧪
Create NodeBalancers
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅