Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-8506] - Misplaced errorGroup prop causing console error #11398

Conversation

pmakode-akamai
Copy link
Contributor

Description 📝

A small, quick PR to fix the misplaced errorGroup prop that was causing a console error.

Note: We will fix the other unrelated console errors in a follow-up PR

Changes 🔄

  • Correctly placed errorGroup in textFieldProps

Target release date 🗓️

N/A

Preview 📷

Before After
Screenshot 2024-12-11 at 4 57 32 PM No console error due to the errorGroup prop

How to test 🧪

  • Go to Create NodeBalancers
  • Ensure no console error when selecting TCP protocol in Configuration panel
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai added the Bug Fixes for regressions or bugs label Dec 11, 2024
@pmakode-akamai pmakode-akamai self-assigned this Dec 11, 2024
@pmakode-akamai pmakode-akamai marked this pull request as ready for review December 11, 2024 11:42
@pmakode-akamai pmakode-akamai requested a review from a team as a code owner December 11, 2024 11:42
@pmakode-akamai pmakode-akamai requested review from abailly-akamai and harsh-akamai and removed request for a team December 11, 2024 11:42
@pmakode-akamai pmakode-akamai changed the title fix: [M3-8506] - Fix misplaced errorGroup prop causing console error fix: [M3-8506] - Misplaced errorGroup prop causing console error Dec 11, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 469 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing469 Passing2 Skipped99m 22s

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 11, 2024
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thx for the fix 👍

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 11, 2024
@pmakode-akamai pmakode-akamai merged commit 3eba173 into linode:develop Dec 12, 2024
23 checks passed
Copy link

cypress bot commented Dec 12, 2024

Cloud Manager E2E    Run #6958

Run Properties:  status check failed Failed #6958  •  git commit 3eba173606: fix: [M3-8506] - Misplaced `errorGroup` prop causing console error (#11398)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #6958
Run duration 31m 44s
Commit git commit 3eba173606: fix: [M3-8506] - Misplaced `errorGroup` prop causing console error (#11398)
Committer Purvesh Makode
View all properties for this run ↗︎

Test results
Tests that failed  Failures 3
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 466
View all changes introduced in this branch ↗︎

Tests for review

Failed  linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Failed  rebuild-linode.spec.ts • 2 failed tests

View Output Video

Test Artifacts
rebuild linode > rebuilds a linode from Community StackScript Screenshots Video
rebuild linode > rebuilds a linode from Account StackScript Screenshots Video
Flakiness  switch-linode-state.spec.ts • 1 flaky test

View Output Video

Test Artifacts
switch linode state > powers on a linode from landing page Screenshots Video
Flakiness  update-linode-labels.spec.ts • 1 flaky test

View Output Video

Test Artifacts
update linode label > updates a linode label from details page Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants