Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8864] - Cypress tests to validate errors in Linode Create Backups tab #11422

Conversation

pmakode-akamai
Copy link
Contributor

Description 📝

Add Cypress test to validate error messages if required options are not selected in the Linode Create Backups tab.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add a Cypress test to validate error messages if required options are not selected in the Linode Create Backups tab.

Target release date 🗓️

N/A

How to test 🧪

  • yarn cy:run -s "cypress/e2e/core/linodes/create-linode.spec.ts"
  • Ensure all tests pass
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@pmakode-akamai pmakode-akamai self-assigned this Dec 16, 2024
@pmakode-akamai pmakode-akamai added the e2e Indicates that a PR touches Cypress tests in some way label Dec 16, 2024
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 467 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing467 Passing2 Skipped91m 18s

@bnussman-akamai bnussman-akamai self-requested a review December 16, 2024 20:46
@pmakode-akamai pmakode-akamai marked this pull request as ready for review December 17, 2024 06:22
@pmakode-akamai pmakode-akamai requested review from a team as code owners December 17, 2024 06:22
@pmakode-akamai pmakode-akamai requested review from jdamore-linode, dwiley-akamai and mjac0bs and removed request for a team December 17, 2024 06:22
@pmakode-akamai pmakode-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 17, 2024
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the test passes and provides coverage for error validation in the original ticket. Thanks!

image

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passes locally & in CI ✅

@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 19, 2024
@pmakode-akamai pmakode-akamai merged commit cbc317e into linode:develop Dec 19, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! e2e Indicates that a PR touches Cypress tests in some way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants