Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-9021] - Various bugs in Managed tables #11431

Merged
merged 8 commits into from
Dec 19, 2024

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Dec 17, 2024

Description 📝

Managed pages needed some 💚 when it came to tablet, mobile, and loading table views. This PR fixes issues across all Managed tabs where mismatches between the number of data columns and table header columns displayed.

Changes 🔄

In addition to the above, this PR:

  • Removes unnecessary left padding for the first column of the Monitors table header
  • Makes the row actions display in the Contacts table consistent with the other tables (it becomes a ... action menu at small screen sizes)
  • Does some linting and other small stylistic code clean up

Target release date 🗓️

1/14

Preview 📷

Videos
🐛 Before After
Monitors Loading State Bug
monitors-prod-loading-bug.mov
monitors-fix-loading-bug.mov
SSH Access Loading State Bug
sshaccess-prod-loading-bug.mov
sshaccess-fix-loading-bug.mov
Contacts Loading State Bug
contacts-prod-loading-bug.mov
contacts-fix-loading-bug.mov
Contacts Col Downsize Bug
contacts-prod-col-downsizing-bug.mov
contacts-fix-col-downsize-bug.mov

How to test 🧪

Prerequisites

(How to setup test environment)

  • In admin, switch on Managed for your account (via a checkbox)
    OR
  • Use the MSW (Legacy, if you want to see factory data)

Reproduction steps

(How to reproduce the issue, if applicable)

  • Go to https://cloud.linode.com/managed/summary or check out develop locally.
  • Visit each of the pages shown in the preview and block network requests to the page's data using browser console.
  • Resize the screen and observe the display issues.

Verification steps

(How to verify changes)

  • Go to http://localhost:3000/managed/summary or check out develop locally.
  • Visit each of the pages shown in the preview and block network requests to the page's data using browser console.
  • Resize the screen and observe the display issues have been fixed.
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@mjac0bs mjac0bs added the Bug Fixes for regressions or bugs label Dec 17, 2024
@mjac0bs mjac0bs self-assigned this Dec 17, 2024
@mjac0bs mjac0bs marked this pull request as ready for review December 18, 2024 21:54
@mjac0bs mjac0bs requested a review from a team as a code owner December 18, 2024 21:54
@mjac0bs mjac0bs requested review from bnussman-akamai and cpathipa and removed request for a team December 18, 2024 21:54
@mjac0bs mjac0bs changed the title fix: [M3-9021] - Fix Managed tables UI fix: [M3-9021] - Various bugs in Managed tables Dec 18, 2024
@bnussman-akamai bnussman-akamai added the Add'tl Approval Needed Waiting on another approval! label Dec 18, 2024
Copy link

Coverage Report:
Base Coverage: 86.97%
Current Coverage: 86.97%

@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 469 passing tests on test run #3 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing469 Passing2 Skipped97m 26s

@jaalah-akamai jaalah-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Dec 19, 2024
@mjac0bs mjac0bs merged commit 58d72d8 into linode:develop Dec 19, 2024
23 checks passed
Copy link

cypress bot commented Dec 19, 2024

Cloud Manager E2E    Run #7007

Run Properties:  status check failed Failed #7007  •  git commit 58d72d8f56: fix: [M3-9021] - Various bugs in Managed tables (#11431)
Project Cloud Manager E2E
Branch Review develop
Run status status check failed Failed #7007
Run duration 27m 29s
Commit git commit 58d72d8f56: fix: [M3-9021] - Various bugs in Managed tables (#11431)
Committer Mariah Jacobs
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 470
View all changes introduced in this branch ↗︎

Tests for review

Failed  cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test

View Output Video

Test Artifacts
Linode Config management > End-to-End > Clones a config Screenshots Video
Flakiness  cypress/e2e/core/parentChild/account-switching.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Parent/Child account switching > From Parent to Child > can switch from Parent account user to Proxy account user from Billing page Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants