-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [M3-9021] - Various bugs in Managed tables #11431
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
requested review from
bnussman-akamai and
cpathipa
and removed request for
a team
December 18, 2024 21:54
mjac0bs
changed the title
fix: [M3-9021] - Fix Managed tables UI
fix: [M3-9021] - Various bugs in Managed tables
Dec 18, 2024
bnussman-akamai
approved these changes
Dec 18, 2024
Coverage Report: ✅ |
Cloud Manager UI test results🎉 469 passing tests on test run #3 ↗︎
|
jaalah-akamai
approved these changes
Dec 19, 2024
jaalah-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Dec 19, 2024
Cloud Manager E2E Run #7007
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Failed #7007
|
Run duration | 27m 29s |
Commit |
58d72d8f56: fix: [M3-9021] - Various bugs in Managed tables (#11431)
|
Committer | Mariah Jacobs |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
470
|
View all changes introduced in this branch ↗︎ |
Tests for review
cypress/e2e/core/linodes/linode-config.spec.ts • 1 failed test
Test | Artifacts | |
---|---|---|
Linode Config management > End-to-End > Clones a config |
Screenshots
Video
|
cypress/e2e/core/parentChild/account-switching.spec.ts • 1 flaky test
Test | Artifacts | |
---|---|---|
Parent/Child account switching > From Parent to Child > can switch from Parent account user to Proxy account user from Billing page |
Screenshots
Video
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Managed pages needed some 💚 when it came to tablet, mobile, and loading table views. This PR fixes issues across all Managed tabs where mismatches between the number of data columns and table header columns displayed.
Changes 🔄
In addition to the above, this PR:
...
action menu at small screen sizes)Target release date 🗓️
1/14
Preview 📷
Videos
monitors-prod-loading-bug.mov
monitors-fix-loading-bug.mov
sshaccess-prod-loading-bug.mov
sshaccess-fix-loading-bug.mov
contacts-prod-loading-bug.mov
contacts-fix-loading-bug.mov
contacts-prod-col-downsizing-bug.mov
contacts-fix-col-downsize-bug.mov
How to test 🧪
Prerequisites
(How to setup test environment)
OR
Reproduction steps
(How to reproduce the issue, if applicable)
Verification steps
(How to verify changes)
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅