upcoming: [M3-8839] - Designate LKE-E clusters with 'Enterprise' chip #11442

mjac0bs · 2024-12-19T15:55:01Z

Description 📝

For listing and viewing cluster information, customers should be able to have explicit indication whether the cluster is an LKE vs LKE-E cluster.

To do this, we will add add an 'ENTERPRISE' chip on the LKE landing page and the cluster details page.

Changes 🔄

Create a new ClusterChip component to display both chip types when applicable
- Provide unit test coverage for new component
Remove the Kubernetes Dashboard button for enterprise clusters (not related to this ticket, but same component, so made the change)
Fix a spacing issue in KubeSpecs due to enterprise versions

Note: Yes, the total price of the LKE-E cluster is inaccurate. This will be addressed by M3-9042.

Target release date 🗓️

1/14 (dev)

Preview 📷

Location	Image
LKE Landing
LKE Details
LKE Details Responsive Design	Screen.Recording.2024-12-19.at.12.35.20.PM.mov

How to test 🧪

Prerequisites

(How to setup test environment)

Have the LKE-E customer tag on your account (see Project Tracker)
Have the feature flag on locally
Have created an LKE-E cluster through the create flow

Verification steps

(How to verify changes)

With the feature flag on, observe the LKE-E cluster chips for your enterprise cluster on the LKE landing page and LKE details page.
Resize the screen to tablet and mobile nd observe that the chips and kube specs display appropriately.
Observe that the Kubernetes Dashboard link is not visible at the top of the summary - this is not supported for LKE-E so it was always disabled for these clusters.
Observe no Enterprise chip when the feature flag is off.
Confirm tests pass:

yarn test ClusterChips

Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support

I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

All unit tests are passing
TypeScript compilation succeeded without errors
Code passes all linting rules

mjac0bs · 2024-12-19T19:22:32Z

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx

@@ -134,7 +139,13 @@ export const KubeClusterSpecs = React.memo((props: Props) => {
  };

  return (
-    <Grid container direction="row" lg={3} xs={12}>
+    <Grid
+      columnGap={matchesColGapBreakpointDown ? 2 : 0}


Unrelated to the intended changes in this PR, but fixes the issue where the kube versions (which are longer because they include patch+lke version) was too close to the data in the right column at certain screen sizes.

Develop This Branch

mjac0bs · 2024-12-19T19:24:33Z

packages/manager/src/features/Kubernetes/ClusterList/ClusterChips.tsx

New component to render both HA and Enterprise chips, since they are use on both landing and details pages.

mjac0bs · 2024-12-19T19:25:34Z

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeSummaryPanel.tsx

+                [theme.breakpoints.down('sm')]: {
+                  '& .MuiChip-root': {
+                    marginRight: 0,
+                  },
+                  flexDirection: 'column',
+                },
+              })}


Styling to prevent the absolutely positioned chips from overlapping with specs text at smaller viewports.

github-actions · 2024-12-20T00:20:06Z

Coverage Report: ✅
Base Coverage: 86.97%
Current Coverage: 86.97%

bnussman-akamai

Looks good pending some test clean up 🧹

packages/manager/src/features/Kubernetes/ClusterList/ClusterChips.test.tsx

…ters

hana-akamai

Looks good! Left some minor non-blocking comments

packages/manager/src/features/Kubernetes/ClusterList/ClusterChips.test.tsx

packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx

…ips.test.tsx Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com>

…il/KubeClusterSpecs.tsx Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com>

linode-gh-bot · 2025-01-02T21:32:22Z

Cloud Manager UI test results

🔺 1 failing test on test run #7 ↗︎

❌ Failing	✅ Passing	↪️ Skipped	🕐 Duration
`1 Failing`	`468 Passing`	`2 Skipped`	`107m 29s`

Details

Failing Tests
	Spec	Test
❌	`lke-update.spec.ts`	LKE cluster updates » can add and delete node pool tags

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts"

mjac0bs · 2025-01-02T21:40:45Z

Test failure is fixed in develop (#11458) and unrelated to the changes in this PR.

…linode#11442) * Create component for rendering cluster chips * Add test coverage for new component * Replace current chip with ClusterChips component * Fix spacing in column specs due to long LKE-E version * Remove Kube dashboard button for LKE-E clusters * Fix the fix for specs spacing * Add changeset * Fix a conditional before I forget * Address feedback - clean up flag mocks in test * Update packages/manager/src/features/Kubernetes/ClusterList/ClusterChips.test.tsx Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> * Update packages/manager/src/features/Kubernetes/KubernetesClusterDetail/KubeClusterSpecs.tsx Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com> --------- Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com>

mjac0bs added the LKE-Enterprise label Dec 19, 2024

mjac0bs self-assigned this Dec 19, 2024

mjac0bs commented Dec 19, 2024

View reviewed changes

mjac0bs added 6 commits December 19, 2024 15:38

Create component for rendering cluster chips

4a35d26

Add test coverage for new component

d146db3

Replace current chip with ClusterChips component

689de08

Fix spacing in column specs due to long LKE-E version

af67a58

Remove Kube dashboard button for LKE-E clusters

14bba5d

Fix the fix for specs spacing

ebe5d1b

mjac0bs marked this pull request as ready for review December 19, 2024 23:39

mjac0bs requested a review from a team as a code owner December 19, 2024 23:39

mjac0bs requested review from bnussman-akamai and cpathipa and removed request for a team December 19, 2024 23:39

mjac0bs force-pushed the M3-8839-add-enterprise-chip-to-lke-e-clusters branch from 8d2d506 to ebe5d1b Compare December 19, 2024 23:41

Add changeset

e96c5ef

mjac0bs added the Ready for Review label Dec 19, 2024

mjac0bs requested a review from hana-akamai December 19, 2024 23:43

Fix a conditional before I forget

d2c81b2

bnussman-akamai approved these changes Jan 2, 2025

View reviewed changes

packages/manager/src/features/Kubernetes/ClusterList/ClusterChips.test.tsx Outdated Show resolved Hide resolved

mjac0bs added 2 commits January 2, 2025 08:30

Merge branch 'develop' into M3-8839-add-enterprise-chip-to-lke-e-clus…

d9f3dcb

…ters

Address feedback - clean up flag mocks in test

e8e8805

mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 2, 2025

hana-akamai approved these changes Jan 2, 2025

View reviewed changes

hana-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! Ready for Review labels Jan 2, 2025

cpathipa approved these changes Jan 2, 2025

View reviewed changes

Update packages/manager/src/features/Kubernetes/ClusterList/ClusterCh…

f18c386

…ips.test.tsx Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com>

Update packages/manager/src/features/Kubernetes/KubernetesClusterDeta…

9543065

…il/KubeClusterSpecs.tsx Co-authored-by: Hana Xu <115299789+hana-akamai@users.noreply.github.com>

mjac0bs merged commit de24b40 into linode:develop Jan 2, 2025
22 of 23 checks passed

This was referenced Jan 8, 2025

Release v1.134.0 - release → staging #11494

Closed

Release v1.134.0 - release → staging #11497

Merged

hana-akamai mentioned this pull request Jan 9, 2025

Release v1.134.0 - release → staging #11503

Merged

jaalah-akamai mentioned this pull request Jan 14, 2025

Release v1.134.0 - staging → master #11519

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

upcoming: [M3-8839] - Designate LKE-E clusters with 'Enterprise' chip #11442

upcoming: [M3-8839] - Designate LKE-E clusters with 'Enterprise' chip #11442

mjac0bs commented Dec 19, 2024 •

edited

Loading

mjac0bs Dec 19, 2024

mjac0bs Dec 19, 2024

mjac0bs Dec 19, 2024

github-actions bot commented Dec 20, 2024 •

edited

Loading

bnussman-akamai left a comment

hana-akamai left a comment

linode-gh-bot commented Jan 2, 2025

mjac0bs commented Jan 2, 2025

upcoming: [M3-8839] - Designate LKE-E clusters with 'Enterprise' chip #11442

upcoming: [M3-8839] - Designate LKE-E clusters with 'Enterprise' chip #11442

Conversation

mjac0bs commented Dec 19, 2024 • edited Loading

Description 📝

Changes 🔄

Target release date 🗓️

Preview 📷

How to test 🧪

Prerequisites

Verification steps

As an Author, to speed up the review process, I considered 🤔

As an Author, before moving this PR from Draft to Open, I confirmed ✅

mjac0bs Dec 19, 2024

Choose a reason for hiding this comment

mjac0bs Dec 19, 2024

Choose a reason for hiding this comment

mjac0bs Dec 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Dec 20, 2024 • edited Loading

bnussman-akamai left a comment

Choose a reason for hiding this comment

hana-akamai left a comment

Choose a reason for hiding this comment

linode-gh-bot commented Jan 2, 2025

Cloud Manager UI test results

🔺 1 failing test on test run #7 ↗︎

Details

Troubleshooting

mjac0bs commented Jan 2, 2025

mjac0bs commented Dec 19, 2024 •

edited

Loading

github-actions bot commented Dec 20, 2024 •

edited

Loading