Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: [M3-8996] - Add test for LKE cluster rename flow #11444

Closed
wants to merge 2 commits into from

Conversation

AzureLatte
Copy link
Contributor

@AzureLatte AzureLatte commented Dec 19, 2024

Description 📝

Add a Cypress integration test using mock data to confirm that the LKE cluster rename flow works as expected.

Changes 🔄

List any change(s) relevant to the reviewer.

  • Add tests in packages/manager/cypress/e2e/core/kubernetes/lke-update.spec.ts
  • Add mockUpdateClusterError in packages/manager/cypress/support/intercepts/lke.ts

How to test 🧪

yarn cy:run -s "cypress/e2e/core/kubernetes/lke-update.spec.ts"

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@AzureLatte AzureLatte self-assigned this Dec 19, 2024
@AzureLatte AzureLatte requested a review from a team as a code owner December 19, 2024 18:11
@AzureLatte AzureLatte requested review from jdamore-linode and removed request for a team December 19, 2024 18:11
@AzureLatte AzureLatte requested a review from a team as a code owner December 19, 2024 18:14
@AzureLatte AzureLatte requested review from dwiley-akamai and harsh-akamai and removed request for a team December 19, 2024 18:14
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🔺 1 failing test on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
1 Failing467 Passing2 Skipped95m 8s

Details

Failing Tests
SpecTest
linode-config.spec.tsEnd-to-End » Clones a config

Troubleshooting

Use this command to re-run the failing tests:

yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts"

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lke-update.spec.ts passes locally & in CI ✅

linode-config.spec.ts failed in CI and I got a couple of failures when running it locally, seems to be flakiness or some intermittent API issues.

We'll also need to resolve the conflict in lke-update.spec.ts

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AzureLatte! Tests look great and pass reliably

Edit: pending conflict Dajahi pointed out!

@jdamore-linode
Copy link
Contributor

Closing this in favor of #11482 which is the same code but with merge conflicts fixed. Wasn't able to push the merge conflicts directly to @AzureLatte's branch since the GH auth changes. cc @dwiley-akamai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants