-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [M3-8996] - Add test for LKE cluster rename flow #11444
Conversation
Cloud Manager UI test results🔺 1 failing test on test run #2 ↗︎
Details
TroubleshootingUse this command to re-run the failing tests: yarn cy:run -s "cypress/e2e/core/linodes/linode-config.spec.ts" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lke-update.spec.ts
passes locally & in CI ✅
linode-config.spec.ts
failed in CI and I got a couple of failures when running it locally, seems to be flakiness or some intermittent API issues.
We'll also need to resolve the conflict in lke-update.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AzureLatte! Tests look great and pass reliably
Edit: pending conflict Dajahi pointed out!
Closing this in favor of #11482 which is the same code but with merge conflicts fixed. Wasn't able to push the merge conflicts directly to @AzureLatte's branch since the GH auth changes. cc @dwiley-akamai |
Description 📝
Add a Cypress integration test using mock data to confirm that the LKE cluster rename flow works as expected.
Changes 🔄
List any change(s) relevant to the reviewer.
How to test 🧪
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅