-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [PDI-3099] - Enable Create Token
button if all visible permissions selected
#11453
fix: [PDI-3099] - Enable Create Token
button if all visible permissions selected
#11453
Conversation
…issions are selected individually (without using 'select all') and child-account is hidden
8cb54f6
to
c9364d3
Compare
Create Token
button if all visible permissions selectedCreate Token
button if all visible permissions selected
Cloud Manager UI test results🎉 472 passing tests on test run #4 ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding and submitting this fix, Zhiwei! The PAT utils are... not a pretty section of code.
Confirmed the fix for accounts where the child account access perm is not visible and confirmed that there are no regressions to unrestricted parent accounts with the child account access perm.
Prod | This Branch |
---|---|
PATSelectBug.mov |
PATSelectFix.mov |
Approving this PR since the original PDI is fixed. While testing I might have discovered another existing issue in prod. When the user individually selects R/W for all perms when child account is hidden, rather than submit a *
as the scope, it lists all the perms individually as rw. We had a similar issue with the 'Select All' button in the past.
cc @jaalah-akamai (or others) - Can you sanity check me on this? For ALL accounts, whether all R/W radio buttons are selected individually or the 'Select All' R/W is used, the scope should be a *
, correct? Will make a follow up ticket, if so.
Confirm that I'm seeing this too only with a restricted parent account. |
Created M3-9070 for the issue mentioned above. I'm going to merge this PR as is. Thanks again @ChihweiLHBird! |
Cloud Manager E2E Run #7047
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7047
|
Run duration | 27m 52s |
Commit |
f818d0be31: fix: [PDI-3099] - Enable `Create Token` button if all visible permissions select...
|
Committer | Zhiwei |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
478
|
View all changes introduced in this branch ↗︎ |
…ions selected (linode#11453) * fix: Enable `Create Token` button if all visible perms selected * Added changeset: `Create Token` button becomes disabled when all permissions are selected individually (without using 'select all') and child-account is hidden * Update the in-line doc
Description 📝
This is to fix the issue where the
Create Token
button becomes disabled when the child-account is hidden and all permissions are individually selected, without using select all options.Feel free to add a Jira ticket to my PR title if you would like to.
Changes 🔄
List any change(s) relevant to the reviewer.
excludedScopesFromSelectAll
with constant values from the map.Preview 📷
How to test 🧪
Reproduction and verification steps
Create Token
button is still disabled (prod version).Create Token
button is enabled (the version in this branch).Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅