-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dep: [M3-8955] - Update react-vnc to 2.0.2 #11467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
Pull requests that update a dependency file
label
Jan 2, 2025
bnussman-akamai
requested review from
mjac0bs and
pmakode-akamai
and removed request for
a team
January 2, 2025 16:00
bnussman-akamai
changed the title
dep: Update
dep: [M3-8955] - Update Jan 2, 2025
react-vnc
to 2.0.2
react-vnc
to 2.0.2
Coverage Report: ✅ |
bnussman-akamai
changed the title
dep: [M3-8955] - Update
dep: [M3-8955] - Update react-vnc to 2.0.2
Jan 2, 2025
react-vnc
to 2.0.2
Cloud Manager UI test results🎉 469 passing tests on test run #2 ↗︎
|
mjac0bs
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Glish seems to be working as expected according to https://techdocs.akamai.com/cloud-computing/docs/access-your-desktop-environment-using-glish; no regressions spotted with this version bump.
pmakode-akamai
approved these changes
Jan 3, 2025
pmakode-akamai
added
Approved
Multiple approvals and ready to merge!
and removed
Add'tl Approval Needed
Waiting on another approval!
labels
Jan 3, 2025
Cloud Manager E2E Run #7033
Run Properties:
|
Project |
Cloud Manager E2E
|
Branch Review |
develop
|
Run status |
Passed #7033
|
Run duration | 27m 22s |
Commit |
18cfc7eed9: dep: [M3-8955] - Update react-vnc to 2.0.2 (#11467)
|
Committer | Banks Nussman |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
1
|
Pending |
2
|
Skipped |
0
|
Passing |
471
|
View all changes introduced in this branch ↗︎ |
This was referenced Jan 8, 2025
dmcintyr-akamai
pushed a commit
to dmcintyr-akamai/manager
that referenced
this pull request
Jan 9, 2025
* update `react-vnc` to `2.0.2` * add changeset --------- Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Approved
Multiple approvals and ready to merge!
Dependencies
Pull requests that update a dependency file
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
react-vnc
to the latest version (2.0.2
)Preview 📷
How to test 🧪
Author Checklists
As an Author, to speed up the review process, I considered 🤔
👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support
As an Author, before moving this PR from Draft to Open, I confirmed ✅