Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dep: [M3-8955] - Update react-vnc to 2.0.2 #11467

Merged
merged 2 commits into from
Jan 3, 2025

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Updates react-vnc to the latest version (2.0.2)
    • There are no breaking changes that I'm aware of!

Preview 📷

Screenshot 2025-01-02 at 10 59 02 AM

How to test 🧪

  • Verify GLISH works as expected with no regressions
Author Checklists

As an Author, to speed up the review process, I considered 🤔

👀 Doing a self review
❔ Our contribution guidelines
🤏 Splitting feature into small PRs
➕ Adding a changeset
🧪 Providing/improving test coverage
🔐 Removing all sensitive information from the code and PR description
🚩 Using a feature flag to protect the release
👣 Providing comprehensive reproduction steps
📑 Providing or updating our documentation
🕛 Scheduling a pair reviewing session
📱 Providing mobile support
♿ Providing accessibility support


  • I have read and considered all applicable items listed above.

As an Author, before moving this PR from Draft to Open, I confirmed ✅

  • All unit tests are passing
  • TypeScript compilation succeeded without errors
  • Code passes all linting rules

@bnussman-akamai bnussman-akamai added the Dependencies Pull requests that update a dependency file label Jan 2, 2025
@bnussman-akamai bnussman-akamai self-assigned this Jan 2, 2025
@bnussman-akamai bnussman-akamai requested a review from a team as a code owner January 2, 2025 16:00
@bnussman-akamai bnussman-akamai requested review from mjac0bs and pmakode-akamai and removed request for a team January 2, 2025 16:00
@bnussman-akamai bnussman-akamai changed the title dep: Update react-vnc to 2.0.2 dep: [M3-8955] - Update react-vnc to 2.0.2 Jan 2, 2025
Copy link

github-actions bot commented Jan 2, 2025

Coverage Report:
Base Coverage: 86.95%
Current Coverage: 86.97%

@bnussman-akamai bnussman-akamai changed the title dep: [M3-8955] - Update react-vnc to 2.0.2 dep: [M3-8955] - Update react-vnc to 2.0.2 Jan 2, 2025
@linode-gh-bot
Copy link
Collaborator

Cloud Manager UI test results

🎉 469 passing tests on test run #2 ↗︎

❌ Failing✅ Passing↪️ Skipped🕐 Duration
0 Failing469 Passing2 Skipped103m 19s

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glish seems to be working as expected according to https://techdocs.akamai.com/cloud-computing/docs/access-your-desktop-environment-using-glish; no regressions spotted with this version bump.

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jan 2, 2025
@pmakode-akamai pmakode-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jan 3, 2025
@bnussman-akamai bnussman-akamai merged commit 18cfc7e into linode:develop Jan 3, 2025
23 checks passed
Copy link

cypress bot commented Jan 3, 2025

Cloud Manager E2E    Run #7033

Run Properties:  status check passed Passed #7033  •  git commit 18cfc7eed9: dep: [M3-8955] - Update react-vnc to 2.0.2 (#11467)
Project Cloud Manager E2E
Branch Review develop
Run status status check passed Passed #7033
Run duration 27m 22s
Commit git commit 18cfc7eed9: dep: [M3-8955] - Update react-vnc to 2.0.2 (#11467)
Committer Banks Nussman
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 471
View all changes introduced in this branch ↗︎

dmcintyr-akamai pushed a commit to dmcintyr-akamai/manager that referenced this pull request Jan 9, 2025
* update `react-vnc` to `2.0.2`

* add changeset

---------

Co-authored-by: Banks Nussman <banks@nussman.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants