M3-2287: add transfer stats to Linode summary panel #4574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jskobos
suggested changes
Feb 28, 2019
| return ( | ||
| <Notice | ||
| text={ | ||
| "Couldn't load Linode's network summary. Please, refresh the page to try loading it again." |
There was a problem hiding this comment.
In some cases (a Linode without an image, or one that is v. new), this request will fail and reloading the page won't help. imo we should just not show this panel if the request fails, rather than have an error state for it, but if we do want to show it, we should:
- Change the error message to
Network transfer information for this Linode is currently unavailable.. - Duplicate the logic used in the stats panels elsewhere on LinodeDetail, so that within 24 hours of creation we show a default non-error message.
There was a problem hiding this comment.
took care of # 1 , @rulikrulit # 2 is the only feedback remaining
| <Typography align="center" variant="h2" className={classes.title}> | ||
| Monthly Network Transfer | ||
| </Typography> | ||
| <CircleProgress /> |
There was a problem hiding this comment.
Should add the mini prop here
added 2 commits
February 28, 2019 09:44
alioso
approved these changes
Feb 28, 2019
added 2 commits
February 28, 2019 11:42
…ulikrulit/manager into feature/M3-2287-transfer-stats
Jskobos
approved these changes
Mar 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change