M3-2899 Fix: Catch deleted events errors #5079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a Linode was deleted, if it had long-running events on it, our linode.events.ts logic was requesting the (nonexistent) Linode after every event, and these errors were uncaught and therefore being reported to Sentry. Fixed this in two ways: - Added a catch block to the requestLinodeForStore method, which drops the error - Added a check in the requestLinodeForStore thunk, so that the API is only hit for a Linode that exists in our store. Since requestLinodeForStore is only called for existing Linodes, this shouldn't cause any issues; however, fix #1 above is enough to resolve this issue, so it might be safer to remove this.
martinmckenna
approved these changes
Jun 18, 2019
There was a problem hiding this comment.
Tested with a large resize. Looks pretty good. There's still a small (very tiny) window where you might get a Not Found error, but I think this will help significantly.
There is still the issue where the events polling is set to 1 second, so in the future we should look into not resetting the events polling if arrayOfEvents.contains(deletedEvents && someEventOnDeletedLinode). Or something like that
johnwcallahan
approved these changes
Jun 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After a Linode was deleted, if it had long-running events on it,
our linode.events.ts logic was requesting the (nonexistent)
Linode after every event, and these errors were uncaught and therefore
being reported to Sentry.
Fixed this in two ways:
drops the error
is only hit for a Linode that exists in our store. Since requestLinodeForStore
is only called for existing Linodes, this shouldn't cause any issues; however,
fix Testing Linode Power #1 above is enough to resolve this issue, so it might be safer to remove this.