M3-3780 Add "Show All" option to Domain Records #6008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This uses the same local storage key as Linodes, Domains, Volumes, and NodeBalancers, so if you select "Show All" on one of those pages, you'll see all of your Domain Records listed as well.
If we don't like this approach, we could make the Domain Records pagination independent or not saved in local storage at all.
Side note: there are some serious performance problems when you have a ton of records on the page (at least running a dev server). E.g. try opening a drawer... all the record rows are re-rendered. Creating a ticket to address separately.
Type of Change
Note to Reviewers
Use production test account #1, Domain "many-domain-records" for a Domain with 150 CNAME records.