Update generate_changelog script to remove PR IDs #6071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously Pull Request IDs were included on each commit message. Example: "My first commit (#1)". These had to be removed manually, so this saves a few steps. I also cleaned up the way the lines were being read from standard output.
acourdavault
reviewed
Feb 3, 2020
| commits = subprocess.check_output(git_log_command, subprocess.STDOUT).decode('utf-8').split('\n') | ||
|
|
||
| # Strip the first and last characters of each line, which are single quotes. | ||
| commits = [c[1:-1] for c in commits] |
acourdavault
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously PR IDs were included on each commit message (e.g.
"Linode Configs (#1234)". These had to be removed manually after generating the changelog, so this just saves a few steps.I also cleaned up the way the lines were being read from standard output.
To test, generate a changelog:
Compare the results to running the same command on develop.