Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [M3-6021] - Invalidate Firewall devices cache when a Linode is deleted #8848

Merged
merged 2 commits into from
Mar 7, 2023
Merged

fix: [M3-6021] - Invalidate Firewall devices cache when a Linode is deleted #8848

merged 2 commits into from
Mar 7, 2023

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • What a Linode that was associated with a firewall was deleted, the Firewalls landing and details page would not update to reflect the removed Linode.
  • This PR React Query-ifys the Firewall Devices endpoint and performorms a cache invalidation on it whenever a Linode is deleted that is associated with that particular firewall
  • Cleans up and modernizes some components in the process

Preview 📷

Before

Screen.Recording.2023-03-06.at.8.01.10.PM.mov

After

Screen.Recording.2023-03-06.at.7.58.23.PM.mov

How to test 🧪

  • Have at least 1 Firewall and 1 Linode
  • Attach the Linode to the Firewall
  • Go delete that Linode
  • Go back to the Firewall landing page
  • Observe that the Linode is no longer listed under that Firewall

@bnussman-akamai bnussman-akamai added Bug Fixes for regressions or bugs React Query Relating to the transition to use React Query labels Mar 7, 2023
@bnussman-akamai bnussman-akamai self-assigned this Mar 7, 2023
@bnussman-akamai bnussman-akamai merged commit f801ead into linode:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hana-akamai hana-akamai hana-akamai approved these changes

@jdamore-linode jdamore-linode jdamore-linode approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Bug Fixes for regressions or bugs React Query Relating to the transition to use React Query
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bnussman-akamai @jdamore-linode @hana-akamai @bnussman