deps: [M3-6230] - Remove unused packages + update lint-staged #8860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
approved these changes
Mar 9, 2023
mjac0bs
reviewed
Mar 10, 2023
| @@ -9193,11 +9181,6 @@ is-obj@^1.0.1: | |||
| resolved "https://registry.yarnpkg.com/is-obj/-/is-obj-1.0.1.tgz#3e4729ac1f5fde025cd7d83a896dab9f4f67db0f" | |||
| integrity sha512-l4RyHgRqGN4Y3+9JHVrNqO+tN0rV5My76uW5/nuO4K1b6vw5G8d/cmFjP9tRfEsdhZNt0IFdZuK/c2Vr4Nb+Qg== | |||
|
|
|||
| is-obj@^2.0.0: | |||
There was a problem hiding this comment.
Is this one fine to remove? yarn why had this output:
=> Found "is-obj@1.0.1"
info Reasons this module exists
- "_project_#lint-staged#stringify-object" depends on it
- Hoisted from "_project_#lint-staged#stringify-object#is-obj"
info Disk size without dependencies: "16KB"
info Disk size with unique dependencies: "16KB"
info Disk size with transitive dependencies: "16KB"
info Number of shared dependencies: 0
✨ Done in 0.37s.
There was a problem hiding this comment.
This is an interesting one because it's needed for stringify-object which is used by lint-staged. However, in the latest versions of lint-staged, this dependency has been removed. So yes we need it, but if we upgrade to latest lint-staged and migrated safely, we could remove it.
There was a problem hiding this comment.
Just checked, we can upgrade to latest since we're using node v18+ - I'll update
jaalah-akamai
changed the title
…y to include in your configuration
bnussman-akamai
approved these changes
Mar 10, 2023
mjac0bs
approved these changes
Mar 10, 2023
mjac0bs
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
package.json.z-index