refactor: [M3-6418] - MUI v5 Migration - Components > Toggle #8990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 1 flaky tests on run #2950 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| smoke - deep link > Go to Profile/Display > by Tab |
Output
Screenshots
Video
|
|
cypress/e2e/linodes/rescue-linode.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| rescue linode > rescue a linode |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
jaalah-akamai
approved these changes
Apr 12, 2023
hana-akamai
reviewed
Apr 12, 2023
| @@ -1,2 +1 @@ | |||
| import Toggle from './Toggle'; | |||
| export default Toggle; | |||
| export { Toggle, ToggleProps } from './Toggle'; | |||
There was a problem hiding this comment.
Exporting ToggleProps like this displays an error in the console and the app doesn't render when running locally. I think this is why we import and export interfaces with underscore in other components
There was a problem hiding this comment.
Oh interesting, I'm gonna fix it by separating the exports
export { Toggle } from './Toggle';
export type { ToggleProps } from './Toggle';There was a problem hiding this comment.
Another reason I don't want to keep the index files around 😖
There was a problem hiding this comment.
Thanks for catching this @hana-linode
hana-akamai
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
<Toggle />but there are no styles applied to it so I just did a clean up and modernization of the componentHow to test 🧪