Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-6397, M3-6416] - MUI v5 Migration - Components > SupportLink, TextTooltip #8993

Merged
merged 3 commits into from
Apr 13, 2023
Merged

refactor: [M3-6397, M3-6416] - MUI v5 Migration - Components > SupportLink, TextTooltip #8993

merged 3 commits into from
Apr 13, 2023

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Apr 12, 2023

Description 📝

What does this PR do?

  • Runs the codemod on TextTooltip.tsx
  • No changes from the codemod on SupportLink.tsx
  • Minor refactoring to use named exports and better interface name for props

Preview 📷

Example TextTooltip:
Screenshot 2023-04-12 at 11 30 25 AM

Example SupportLink:
Screenshot 2023-04-12 at 11 33 06 AM

How to test 🧪

What are the steps to reproduce the issue or verify the changes?
Check areas of the app where the SupportLink and TextTooltip exist to check that there are no styling regressions.

SupportLink:

  • Check Linode Details > SMTP warning notice > "open a support ticket" or other places (generally notices/error messages) where we're linking to Support

TextTooltip:

  • Check the Linode Details > Storage > Resize > "Check disk usage" tooltip

@mjac0bs mjac0bs self-assigned this Apr 12, 2023
@mjac0bs mjac0bs changed the title refactor: [M3-6397, M3 6416] - MUI v5 Migration - Components > SupportLink, TextTooltip refactor: [M3-6397, M3-6416] - MUI v5 Migration - Components > SupportLink, TextTooltip Apr 12, 2023
jaalah
jaalah approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@jaalah jaalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cpathipa cpathipa added the Approved Multiple approvals and ready to merge! label Apr 13, 2023
@mjac0bs mjac0bs merged commit 3761ad3 into linode:develop Apr 13, 2023
@bnussman-akamai bnussman-akamai mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpathipa cpathipa cpathipa approved these changes

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@jaalah jaalah jaalah approved these changes

Assignees

@mjac0bs mjac0bs

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjac0bs @jaalah @bnussman-akamai @cpathipa