refactor: [M3-6414, M3-6415] - MUIv5 Migration - Components > TagsInput, TagsPanel #8995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjac0bs
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
No regressions that I could see. 🚢 And thanks for fixing the stories.
I have noticed that the BetaChip story is messed up somehow (actually, I think the component might be) because the chip in dark mode is not any different from different from light mode. And toggling the color in the Component API has no effect. But that's pretty far out of the intended scope this PR.
bnussman-akamai
approved these changes
Apr 13, 2023
|
@hana-linode Let's add a Tech Stories section and changelog entry before this is merged in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
How to test 🧪