fix: [M3-6472] - [Marketplace] One Click Cluster - UDF Caching issue #8997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
requested changes
Apr 13, 2023
|
|
||
| const styled = withStyles(styles); | ||
|
|
||
| export default styled(RenderGuard<CombinedProps>(UserDefinedSelect)); | ||
| export default styled(UserDefinedSelect); |
There was a problem hiding this comment.
Can we switch to a useStyles hook?
bnussman-akamai
approved these changes
Apr 13, 2023
...es/manager/src/features/StackScripts/UserDefinedFieldsPanel/FieldTypes/UserDefinedSelect.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| export default styled(RenderGuard<CombinedProps>(UserDefinedSelect)); | ||
| export default UserDefinedSelect; |
There was a problem hiding this comment.
Consider removing default export
…nel/FieldTypes/UserDefinedSelect.tsx Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
hana-akamai
approved these changes
Apr 13, 2023
bnussman-akamai
added
Approved
|
@cpathipa Can we add a changelog entry before merging? Thanks! |
1 failed and 2 flaky tests on run #2983 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| smoke - deep link > Go to Profile/Display > by Tab |
Output
Screenshots
Video
|
|
objectStorage/object-storage.e2e.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| object storage end-to-end tests > can upload, access, and delete objects |
Output
Screenshots
Video
|
|
account/sms-verification.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| SMS phone verification > can opt into SMS phone verification |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Preview 📷
Remove this section or include a screenshot or screen recording of the change
How to test 🧪
What are the steps to reproduce the issue or verify the changes?
How do I run relevant unit or e2e tests?