-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-6427] - Add No Results section for Marketplace Search #8999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we're doing this! Seconding @jdamore-linode's request to center the text horizontally. And I'm wondering about the overall placement of the text within that container.
1 flaky tests on run #3058 ↗︎
Details:
cypress/e2e/domains/smoke-create-domain-records.spec.ts • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Thank you @jdamore-linode and @mjac0bs thank you for the feedback, I will circle back with UX on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree with checking on the centered-within-container option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpicks on copy: I'm wondering if clearer copy might read: "Sorry, no results matched your search for "datadog". Please try another term." Thought process being:
What do others (and UX) think? |
@mjac0bs Agreed that "Sorry, no results matched your search for "datadog" sounds clearer. I don't think we even need the second sentence as it's pretty obvious that the user should search for a different term |
packages/manager/src/features/linodes/LinodesCreate/AppPanelSection.tsx
Outdated
Show resolved
Hide resolved
Let's remember to update changelog too 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a changelog update and this looks like it's good to go.
Description 📝
Add No Results section for Marketplace Search
Preview 📷
Remove this section or include a screenshot or screen recording of the change
How to test 🧪
How do I run relevant unit or e2e tests?