Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-6312] - Clear Kubernetes Delete Dialog when it is reopened #9000

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • Clears the Kubernetes Delete Dialog onSuccess so that the dialog input is empty the next time it is opened
  • Thank you @jdamore-linode for finding this

Before 😖

Screen.Recording.2023-04-13.at.11.33.13.AM.mov

After 🎉

Screen.Recording.2023-04-13.at.11.33.29.AM.mov

How to test 🧪

  • Make sure the Kubernetes Delete Dialog clears when reopening it

@bnussman-akamai bnussman-akamai added Bug Fixes for regressions or bugs Ready for Review labels Apr 13, 2023
@bnussman-akamai bnussman-akamai self-assigned this Apr 13, 2023
Copy link
Contributor

@cpathipa cpathipa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @bnussman-akamai! Sorry for the CI failure; that agent is out of disk space. Confirmed the issue is fixed, and I'm also running the e2e tests locally so I'll circle back if there are any relevant failures (can't imagine there will be)

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Apr 13, 2023
@bnussman-akamai bnussman-akamai merged commit 79e7bf5 into linode:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants