refactor: [M3-6304] - MUI v5 Migration - ConditionalWrapper
#9002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
commented
Apr 14, 2023
| @@ -12,7 +10,7 @@ const useStyles = makeStyles()((theme: Theme) => ({ | |||
| display: 'flex', | |||
| alignItems: 'flex-start', | |||
| cursor: 'pointer', | |||
| padding: theme.spacing(1) + theme.spacing(0.5), | |||
There was a problem hiding this comment.
This was probably left over from MUI v4. theme.spacing() use to return a number, now it returns a string so this line actually caused string concatenation which is not what we want. This might result in some minor UI changes, but this restores the original intention.
| @@ -48,7 +46,7 @@ const useStyles = makeStyles()((theme: Theme) => ({ | |||
| }, | |||
| }, | |||
| left: { | |||
| left: -(theme.spacing(1) + theme.spacing(0.5)), | |||
There was a problem hiding this comment.
Same as other comment. string concatenation here was probably not intended
Passing run #2984 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
dwiley-akamai
approved these changes
Apr 14, 2023
jaalah-akamai
approved these changes
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
<ConditionalWrapper />because it was a bit extra and only consumed onceHow to test 🧪