Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-6496] - Add Adobe Analytics custom event tracking #9004

Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
85f5a35
Add AA launch scripts and DCR on tracked events
mjac0bs Apr 12, 2023
ee460fc
Update satellite.track function to use generic, single identifier
mjac0bs Apr 13, 2023
dda27ec
Update launch script src assignment with logic for additional envs
mjac0bs Apr 13, 2023
92e8d42
Use a single env var from Jenkins
mjac0bs Apr 13, 2023
c582034
Disable tracking on custom events in Adobe for now
mjac0bs Apr 13, 2023
3130710
Cleanup
mjac0bs Apr 14, 2023
9f7b914
Enable direct call rule for AA custom event tracking
mjac0bs Apr 14, 2023
8a7c482
Add AA launch scripts and DCR on tracked events
mjac0bs Apr 12, 2023
5a4adb7
Update satellite.track function to use generic, single identifier
mjac0bs Apr 13, 2023
e855860
Update launch script src assignment with logic for additional envs
mjac0bs Apr 13, 2023
dfaf6af
Use a single env var from Jenkins
mjac0bs Apr 13, 2023
df22a2c
Disable tracking on custom events in Adobe for now
mjac0bs Apr 13, 2023
5ad5625
Cleanup
mjac0bs Apr 14, 2023
bdc5802
Only append Adobe Analytics script with valid url
mjac0bs Apr 18, 2023
765fe70
Merge branch 'M3-6462-integrate-adobe-analytics' into M3-6496-add-ado…
mjac0bs Apr 18, 2023
94489c0
Prevent errors if AA env is not defined
mjac0bs Apr 18, 2023
ab2b003
Update sendEvent
mjac0bs Apr 19, 2023
787b729
Test if loadScript works instead
mjac0bs Apr 19, 2023
f9d492a
Revert previous commit to move location of script
mjac0bs Apr 20, 2023
ff826e3
Merge branch 'develop' into M3-6496-add-adobe-analytics-custom-event-…
mjac0bs Apr 21, 2023
e39a7f1
Log error when sendEvent fails
mjac0bs Apr 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Test if loadScript works instead
  • Loading branch information
mjac0bs committed Apr 19, 2023
commit 787b729816ae0379124705b9fe8bbacc99df072a
6 changes: 1 addition & 5 deletions packages/manager/src/App.tsx
Original file line number Diff line number Diff line change
@@ -86,11 +86,7 @@ export class App extends React.Component<CombinedProps, State> {

// Load Adobe Analytics Launch Script
if (!!ADOBE_ANALYTICS_URL) {
const script = document.createElement('script');
// eslint-disable-next-line scanjs-rules/assign_to_src
script.src = `${ADOBE_ANALYTICS_URL}`;
script.async = true;
document.head.appendChild(script);
loadScript(ADOBE_ANALYTICS_URL);
}

/**