Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [M3-6024] – Upgrade NR to v1230 #9005

Merged
merged 4 commits into from
Apr 19, 2023

Conversation

dwiley-akamai
Copy link
Contributor

Description πŸ“

Although the error described in the ticket does not seem to be happening anymore, I did notice that we were significantly behind on the NR version we were using (v1184).

This PR brings us up to the latest NR version (v1230).

How to test πŸ§ͺ

I believe the easiest way to test this locally would be to:

  1. Set this condition to true:

    if (import.meta.env.PROD && !import.meta.env.REACT_APP_DISABLE_NEW_RELIC) {

  2. Go to your localhost and check the network requests. You should see POST requests to bam.nr-data.net and somewhere in the URL you should see v=1.230.0 (this confirms the version upgrade)

(note: depending on your browser configurations, these requests may be filtered out and won't display. For example, I don't see the requests in Chrome, but I see them in Firefox)

@dwiley-akamai dwiley-akamai self-assigned this Apr 14, 2023
@cypress
Copy link

cypress bot commented Apr 14, 2023

1 flaky tests on run #2990 β†—οΈŽ

0 149 3 0 Flakiness 1

Details:

Fixed syntax errors and confirmed the requests go through as intended
Project: Cloud Manager E2E Commit: a0b21b8900
Status: Passed Duration: 14:18 πŸ’‘
Started: Apr 14, 2023 9:40 PM Ended: Apr 14, 2023 9:54 PM
FlakinessΒ  cypress/e2e/objectStorage/object-storage-errors.spec.ts β€’ 1 flaky test

View Output Video

Test Artifacts
object storage failure paths > shows error upon object upload failure Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@bnussman-akamai bnussman-akamai added the Approved Multiple approvals and ready to merge! label Apr 17, 2023
@jaalah-akamai jaalah-akamai merged commit da3bbee into linode:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants