Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [M3-6316, M3-6317] MUI v5 Migration - Components > DateTimeDisplay, DebouncedSearchTextField #9007

Conversation

mjac0bs
Copy link
Contributor

@mjac0bs mjac0bs commented Apr 17, 2023

Description 📝

What does this PR do?

  • Ran the tss-react codemod on DebouncedSearchTextField, but then replaced with styled since it was such a small change
  • No styles to run codemod on DateTimeDisplay
  • Modernized both components by using named exports and better prop interface names

Preview 📷

DebouncedSearchTextField:

image

DateTimeDisplay:

Screenshot 2023-04-17 at 7 58 20 AM

How to test 🧪

What are the steps to reproduce the issue or verify the changes?

How do I run relevant unit or e2e tests?

yarn test DateTimeDisplay

@cypress
Copy link

cypress bot commented Apr 17, 2023

1 flaky tests on run #3050 ↗︎

0 149 3 0 Flakiness 1

Details:

Prevent search icon from turning blue on hover
Project: Cloud Manager E2E Commit: 3b3d295da6
Status: Passed Duration: 15:17 💡
Started: Apr 18, 2023 10:14 PM Ended: Apr 18, 2023 10:29 PM
Flakiness  cypress/e2e/linodes/rescue-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rescue linode > rescue a linode Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mjac0bs
Copy link
Contributor Author

mjac0bs commented Apr 18, 2023

@bnussman-akamai Thanks - did that clean up in c058760.

@jaalah-akamai jaalah-akamai added the Add'tl Approval Needed Waiting on another approval! label Apr 19, 2023
@mjac0bs mjac0bs merged commit b644d7e into linode:develop Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add'tl Approval Needed Waiting on another approval! Ready for Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants