fix: [M3-6480] - Fix blank Node Pool plan selection #9009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
…k-plan-selection Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
hkhalil-akamai
commented
Apr 17, 2023
| const [_types, setNewType] = React.useState<ExtendedTypeWithCount[]>( | ||
| addCountToTypes(types) | ||
| const [typeCountMap, setTypeCountMap] = React.useState<Map<string, number>>( | ||
| new Map() |
There was a problem hiding this comment.
Decided to use a Map here instead of an index signature object because those can lead to runtime errors without noUncheckedIndexedAccess enabled:
const map1: { [key: string]: number } = {"type1": 0};
const type2Count: number = map1["type2"]; # no type error
vs with Map:
const map1: Map<string, number> = new Map([[ "type1", 0 ]]);
const type2Count: number = map1.get("type2"); # type error: number | undefined is not assignable to number.
Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
bnussman-akamai
requested changes
Apr 17, 2023
...nager/src/features/Kubernetes/KubernetesClusterDetail/NodePoolsDisplay/AddNodePoolDrawer.tsx
Outdated
Show resolved
Hide resolved
2 flaky tests on run #3069 ↗︎
Details:
|
|||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| rescue linode > rescue a linode |
Output
Screenshots
Video
|
|
objectStorage/object-storage.e2e.spec.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| object storage end-to-end tests > can upload, access, and delete objects |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
bnussman-akamai
approved these changes
Apr 18, 2023
jaalah-akamai
added
Approved
…k-plan-selection Co-authored-by: Hussain Khalil <hussain@sanpilot.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Fixes a bug introduced in #8840 that causes the
AddNodePooldrawer to not show any plans in certain situations.Also included are basic unit tests that validate the fix and small amendments to the recent
useQueryClientPR.Preview 📷
How to test 🧪
AddNodePoolDrawerappears and displays all plan types and details.