fix: [M3-6442] - Inefficient firewall custom ports regex

[abailly-akamai]

Description 📝

Fix a codeQL inefficient regex warning for firewall custom ports (exponential backtracking on strings containing many repetitions of '-') in the firewall rule drawer.

I increased the regex matching specificity to only match:
42
1-10
1,2,3,4,5

and disallow things like:
1--10
1-2-3
1,2,3-4-5
1-2,3-4

along with extra spaces etc

Preview 📷

How to test 🧪

• pull code locally, and add some rules at /firewalls/[id]/rules
• yarn test FirewallRuleDrawer
  or
• test regex at https://regex101.com/ or other online tool

[bnussman-akamai]

With the current regex, I can't create a firewall with the port to a comma separated list (1,2,3,4,5)

[abailly-akamai]

@bnussman-akamai ah yeah good catch, we are formatting the input so the regex had to allow for whitespace. Updated it and added tests to cover for those cases for good measure:

• 42
• 1-10
• 1,2,3,4,5
• 1, 2, 3, 4, 5

[hkhalil-akamai]

Should we add the additional restriction that the port must be <= 65535?

[abailly-akamai]

@hkhalil-akamai IMO It's better to keep that validation only on the back-end (shall it ever change) and it's not a formatting validation which this PR is meant to target