Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: README.md Validation Version Badge Label #9011

Merged
merged 4 commits into from
Apr 18, 2023
Merged

fix: README.md Validation Version Badge Label #9011

merged 4 commits into from
Apr 18, 2023

Conversation

bnussman-akamai
Copy link
Member

Description 📝

  • The badge for the validation said api-v4 on accident. This updates the badge to show the correct label

Preview 📷

Before

Screenshot 2023-04-17 at 3 00 43 PM

After

Screenshot 2023-04-17 at 3 03 16 PM

How to test 🧪

  • Use Github's view feature to see the README.md

@bnussman-akamai bnussman-akamai added the Documentation Improving / adding to our documentation label Apr 17, 2023
@bnussman-akamai bnussman-akamai self-assigned this Apr 17, 2023
mjac0bs
mjac0bs approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! 🚢

@cpathipa cpathipa added the Approved Multiple approvals and ready to merge! label Apr 17, 2023
@cypress
Copy link

cypress bot commented Apr 17, 2023 •
edited
Loading

1 flaky tests on run #3027 ↗︎

0 149 3 0 Flakiness 1

Details:

Merge branch 'develop' into fix/readme-label
Project: Cloud Manager E2E Commit: a3417a43c3
Status: Passed Duration: 15:53 💡
Started: Apr 18, 2023 4:37 PM Ended: Apr 18, 2023 4:53 PM
Flakiness  cypress/e2e/linodes/clone-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
clone linode > clone linode Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@bnussman-akamai bnussman-akamai merged commit 18fd5a7 into linode:develop Apr 18, 2023
@bnussman-akamai bnussman-akamai mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abailly-akamai abailly-akamai abailly-akamai approved these changes

@cpathipa cpathipa cpathipa approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

Assignees

@bnussman-akamai bnussman-akamai

Labels
Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bnussman-akamai @mjac0bs @cpathipa @abailly-akamai @bnussman