Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: slightly improve PR template #9029

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

jaalah-akamai
Copy link
Contributor

@jaalah-akamai jaalah-akamai commented Apr 19, 2023

Description 📝

Slightly improves the PR template

  • Adds "Major Changes" section for changes you want to highlight
  • Adds table for preview section
  • Be more explicit for testing section
  • Add note syntax for "Commit message" section

@cypress
Copy link

cypress bot commented Apr 19, 2023

1 flaky tests on run #3062 ↗︎

0 149 3 0 Flakiness 1

Details:

chore: bold test instructions
Project: Cloud Manager E2E Commit: 6c4a45e030
Status: Passed Duration: 17:02 💡
Started: Apr 19, 2023 4:22 PM Ended: Apr 19, 2023 4:39 PM
Flakiness  cypress/e2e/linodes/rescue-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
rescue linode > rescue a linode Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

docs/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
docs/PULL_REQUEST_TEMPLATE.md Show resolved Hide resolved
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation labels Apr 19, 2023
@jaalah-akamai jaalah-akamai merged commit 9940b9d into linode:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Documentation Improving / adding to our documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants