fix: [M3-6446] - Fix code scanning alert that DOM text is reinterpreted as HTML #9032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
Security
1 flaky tests on run #3070 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| SMS phone verification > can opt into SMS phone verification |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
jaalah-akamai
approved these changes
Apr 20, 2023
hana-akamai
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
sanitize-urlbecause it already is already baked into our reposanitize-html, which we also have installed, but Braintree'ssanitize-urlseems like a better fit for this use caseMajor Changes 🔄
<ExternalLink />component now sanitizes any link it is givenHow to test 🧪
<ExternalLink />component still works as expectedSupportSearchLanding(http://localhost:3000/support/search/?query=) still works as expected because this is what triggered the alert