Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [M3-6501] - Add Metadata migrate warning #9033

Merged

Conversation

hana-akamai
Copy link
Contributor

Description 📝

Add warning text to the Migrate Linode dialog when migrating from a Data Center that supports Metadata to a Data Center that doesn't

Preview 📷

Screen.Recording.2023-04-19.at.4.26.35.PM.mov

How to test 🧪

  • Turn on the MSW and migrate a Linode from a Metadata supported DC (London, UK) to a Non-Metadata supported DC (any other DC).
  • You should see the warning notice update with an additional bullet. Reopening the Dialog should clear the additional bullet
  • You should not see the additional bullet when Migrating from a Non-Metadata supported DC to a supported Metadata DC

@hana-akamai hana-akamai added Project: Metadata Related to Metadata project Ready for Review labels Apr 19, 2023
@hana-akamai hana-akamai self-assigned this Apr 19, 2023
@cypress
Copy link

cypress bot commented Apr 19, 2023

1 flaky tests on run #3160 ↗︎

0 151 3 0 Flakiness 1

Details:

Merge branch 'develop' into M3-6501-metadata-migrate-warning
Project: Cloud Manager E2E Commit: 4151bb03bb
Status: Passed Duration: 14:30 💡
Started: Apr 24, 2023 10:22 PM Ended: Apr 24, 2023 10:36 PM
Flakiness  cypress/e2e/linodes/create-linode.spec.ts • 1 flaky test

View Output Video

Test Artifacts
create linode > creates a nanode Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@abailly-akamai
Copy link
Contributor

@hana-linode what is MSW and how to you turn it on?

@hana-akamai
Copy link
Contributor Author

@abailly-akamai It's the Mock Service Worker and we can turn it on in the lower left corner of the browser

Screen.Recording.2023-04-20.at.11.31.57.AM.mov

Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but somehow the new warning is not showing after turning on the MSW and testing the feature (I wonder if I missed step to test this properly?) - also left a couple of non-blocking comments

Screenshot 2023-04-20 at 12 06 46 PM

@hana-akamai
Copy link
Contributor Author

@abailly-akamai Do you have the metadata feature flag turned on in the dev tools?
image

@abailly-akamai
Copy link
Contributor

@hana-linode ah yes, that was it. I had it on but did not realize it gets turned off after a page reload - looks good!

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM -- observed the warning bullet point's existence and non-existence when migrating as described.

CHANGELOG.md Outdated Show resolved Hide resolved
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Apr 20, 2023
@hkhalil-akamai
Copy link
Contributor

I know I'm coming late to this PR, and I don't want to cause it to be delayed, but has anyone from UX given feedback? I'm concerned that a user might miss the additional bullet point (since they may open the migration dialog, read the warning and then go about customizing the options).

@hana-akamai
Copy link
Contributor Author

@hkhalil-akamai I haven't heard back from Matthew but Joe Michelini (original reporter) approved so I'm going to go ahead and merge this

@hana-akamai hana-akamai merged commit 8de0277 into linode:develop Apr 24, 2023
@hana-akamai hana-akamai deleted the M3-6501-metadata-migrate-warning branch April 24, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Project: Metadata Related to Metadata project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants