-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-6501] - Add Metadata migrate warning #9033
feat: [M3-6501] - Add Metadata migrate warning #9033
Conversation
1 flaky tests on run #3160 ↗︎
Details:
cypress/e2e/linodes/create-linode.spec.ts • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
@hana-linode what is MSW and how to you turn it on? |
@abailly-akamai It's the Mock Service Worker and we can turn it on in the lower left corner of the browser Screen.Recording.2023-04-20.at.11.31.57.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/manager/src/features/linodes/MigrateLinode/MigrateLinode.tsx
Outdated
Show resolved
Hide resolved
@abailly-akamai Do you have the metadata feature flag turned on in the dev tools? |
@hana-linode ah yes, that was it. I had it on but did not realize it gets turned off after a page reload - looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM -- observed the warning bullet point's existence and non-existence when migrating as described.
packages/manager/src/features/linodes/MigrateLinode/MigrateLinode.tsx
Outdated
Show resolved
Hide resolved
I know I'm coming late to this PR, and I don't want to cause it to be delayed, but has anyone from UX given feedback? I'm concerned that a user might miss the additional bullet point (since they may open the migration dialog, read the warning and then go about customizing the options). |
@hkhalil-akamai I haven't heard back from Matthew but Joe Michelini (original reporter) approved so I'm going to go ahead and merge this |
Description 📝
Add warning text to the Migrate Linode dialog when migrating from a Data Center that supports Metadata to a Data Center that doesn't
Preview 📷
Screen.Recording.2023-04-19.at.4.26.35.PM.mov
How to test 🧪