refactor: Improve Object Storage E2E flake related to ACL select #9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdamore-linode
added
e2e
1 flaky tests on run #3076 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Migrate Linode With Firewall > migrates linode with firewall - real data |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
dwiley-akamai
approved these changes
Apr 21, 2023
mjac0bs
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
autocompletePopperUI helper to interact with the Object Storage ACL select element, eliminating the issue that causes occasional flakiness with the Object Storage end-to-end tests.EnhancedSelectcomponent's menu list items in a div with adata-qa-autocomplete-popperattribute. This was done so that our e2eautocompletePopperUI helper works with our old selects (EnhancedSelect) in addition to newer selects based on MUI. I was reluctant to change the DOM structure but haven't observed any issues or changes stemming from this addition -- happy to revisit if the team would prefer another approach.How to test 🧪
yarn && yarn build && yarn start:manager:ciand then:yarn cy:run -s "cypress/e2e/objectStorage/object-storage.e2e.spec.ts"Confirm that the tests pass. Optionally, run the test multiple times to ensure there is no flake related to the ACL select.