feat: [M3-5561] - Add Private IP checkbox when cloning a Linode #9039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #3167 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
| } | ||
|
|
||
| const AddonsPanel = (props: Props) => { | ||
| export type AddonsPanelProps = Props; |
There was a problem hiding this comment.
Do we need to do an alias here? Could we just name Props AddonsPanelProps?
bnussman-akamai
approved these changes
Apr 21, 2023
dwiley-akamai
approved these changes
Apr 21, 2023
There was a problem hiding this comment.
Could we make use of factories in this file instead of hardcoding all the mocked data?
hkhalil-akamai
approved these changes
Apr 22, 2023
packages/manager/src/features/linodes/LinodesCreate/AddonsPanel.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/features/linodes/LinodesCreate/AddonsPanel.tsx
Outdated
Show resolved
Hide resolved
hkhalil-akamai
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Added Private IP checkbox when cloning a Linode.
Unit test coverage for
AddonsPanelPreview 📷
Include a screenshot or screen recording of the change
How to test 🧪