Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-6307] - MUIv5 Migration - SRC > Components > CopyTooltip #9040

Merged
merged 4 commits into from
Apr 25, 2023
Merged

refactor: [M3-6307] - MUIv5 Migration - SRC > Components > CopyTooltip #9040

merged 4 commits into from
Apr 25, 2023

Conversation

cpathipa
Copy link
Contributor

Description 📝

  • Migrate CopyTooltip component from JSS to tss-react.
  • Use named export instead of default

How to test 🧪

  • Validate CopyTooltip component in storybook
  • yarn test
  • yarn cy:run

@cpathipa cpathipa self-assigned this Apr 20, 2023
@cpathipa @bnussman-akamai
Update packages/manager/src/components/CopyTooltip/CopyTooltip.storie…
7bf423f 
…s.mdx

Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
@cpathipa cpathipa added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Apr 21, 2023
mjac0bs
mjac0bs reviewed Apr 21, 2023
View reviewed changes
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update the changelog.

Storybook page renders correctly. ✅

packages/manager/src/components/CopyTooltip/CopyTooltip.tsx Outdated Show resolved Hide resolved
@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Apr 21, 2023
@cpathipa cpathipa merged commit c619eb3 into linode:develop Apr 25, 2023
@bnussman-akamai bnussman-akamai mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@mjac0bs mjac0bs mjac0bs approved these changes

Assignees

@cpathipa cpathipa

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpathipa @mjac0bs @bnussman-akamai