chore: assets and utilities clean up #9041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #3155 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
| @@ -1,5 +1,3 @@ | |||
| const escapeStringForCLI = (value: string) => { | |||
| export const escapeStringForCLI = (value: string) => { | |||
| return value.replace(/(["'$`\\])/g, '\\$1'); | |||
| }; | |||
There was a problem hiding this comment.
Just a potential for some more cleanup, possibly in a separate PR: This util essentially does the same as https://github.com/linode/manager/blob/develop/packages/manager/src/utilities/generate-cli.ts#L2-L10. However the one in generate-cli is more comprehensive in what it handles. Do we want to move forward with just one solution?
There was a problem hiding this comment.
Made myself a note to revisit this
jaalah-akamai
approved these changes
Apr 24, 2023
mjac0bs
approved these changes
Apr 24, 2023
| sortCreatedDESC, | ||
| filter(propSatisfies(startsWith('private'), 'id')) | ||
| ); | ||
| import { always, cond, groupBy, propOr } from 'ramda'; |
mjac0bs
added
Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
packages/manager/src/assets/andpackages/manager/src/utilities/Preview 📷
How to test 🧪