chore: add more hook rules to eslint #9043
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Adding a couple rules that should prevent a commit from going through if condition met (before that contributors may have been able to see the error in the IDE but commit could go through nonetheless
I set
react-hooks/exhaustive-deps
as a warning for now (there's 80+ offenders in the codebase) but since we only lint staged code anyway it shouldn't affect velocity either way unless you start editing and attempt to commit said offender