Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add more hook rules to eslint #9043

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

abailly-akamai
Copy link
Contributor

@abailly-akamai abailly-akamai commented Apr 21, 2023

Description 📝

Adding a couple rules that should prevent a commit from going through if condition met (before that contributors may have been able to see the error in the IDE but commit could go through nonetheless

I set react-hooks/exhaustive-deps as a warning for now (there's 80+ offenders in the codebase) but since we only lint staged code anyway it shouldn't affect velocity either way unless you start editing and attempt to commit said offender

@abailly-akamai abailly-akamai self-assigned this Apr 21, 2023
@cypress
Copy link

cypress bot commented Apr 21, 2023

1 flaky tests on run #3115 ↗︎

0 149 3 0 Flakiness 1

Details:

chore: - add more eslint rules
Project: Cloud Manager E2E Commit: 876cfb1eea
Status: Passed Duration: 15:10 💡
Started: Apr 21, 2023 6:03 PM Ended: Apr 21, 2023 6:18 PM
Flakiness  cypress/e2e/account/service-transfer.spec.ts • 1 flaky test

View Output Video

Test Artifacts
Account service transfers > can navigate to service transfers landing page Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@abailly-akamai abailly-akamai merged commit c6d5e52 into linode:develop Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants