Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: [M3-6318] - MUI v5 - Components > DeletionDialog #9047

Merged
merged 10 commits into from
Apr 24, 2023
Merged

refactor: [M3-6318] - MUI v5 - Components > DeletionDialog #9047

merged 10 commits into from
Apr 24, 2023

Conversation

jaalah-akamai
Copy link
Contributor

Description 📝

Refactors src/components/DeletionDialog/DeletionDialog.tsx to remove JSS

Major Changes 🔄

  • Updated references for named export

Preview 📷

Before After
Screen Shot 2023-04-24 at 11 28 54 AM Screen Shot 2023-04-24 at 11 29 07 AM

How to test 🧪

  1. yarn dev
  2. Go to http://localhost:3000/linodes
  3. Attempt to delete any linode and observe no differences
  4. N/A

@jaalah-akamai jaalah-akamai marked this pull request as draft April 24, 2023 15:37
@jaalah-akamai
Copy link
Contributor Author

Pending #9020

@jaalah-akamai jaalah-akamai marked this pull request as ready for review April 24, 2023 15:39
@cypress
Copy link

cypress bot commented Apr 24, 2023 •
edited
Loading

Passing run #3156 ↗︎

0 151 3 0 Flakiness 0

Details:

Update changelog
Project: Cloud Manager E2E Commit: d77edcf037
Status: Passed Duration: 15:07 💡
Started: Apr 24, 2023 9:49 PM Ended: Apr 24, 2023 10:04 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Ready for Review labels Apr 24, 2023
@jaalah-akamai jaalah-akamai merged commit 1035fb2 into linode:develop Apr 24, 2023
@jaalah-akamai jaalah-akamai deleted the M3-6318 branch April 24, 2023 21:13
@bnussman-akamai bnussman-akamai mentioned this pull request May 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnussman-akamai bnussman-akamai bnussman-akamai approved these changes

@dwiley-akamai dwiley-akamai dwiley-akamai approved these changes

Assignees

@jaalah-akamai jaalah-akamai

Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jaalah-akamai @dwiley-akamai @bnussman-akamai @mjac0bs @jaalah