fix: [M3-6510] - Modifying Configuration Profile in Cloud breaks with VLANs

[cpathipa]

Description 📝

Fix - Modifying Configuration Profile in Cloud breaks with VLANs

Preview 📷

Include a screenshot or screen recording of the change

Before	After

How to test 🧪

How to reproduce the issue (if applicable)?

• Checkout to develop branch
• Create a Linode in Cloud Manager with a standard image (Ubuntu, for example) and no VLAN
• After the Linode provisions, edit the configuration profile in Cloud Manager, adding a VLAN (with or without an IPAM address), then Save the configuration profile
• Edit the configuration profile again, then try to either a) add another VLAN, b) remove the existing VLAN by switching eth1 to None, or c) do literally nothing other than immediately Save the configuration profile (with no changes made).

How to verify changes?

• Follow the above steps to create Linode, configure and update with VLAN

How to run Unit or E2E tests?

• yarn test
• yarn cy:run

[cypress]

Passing run #3197 ↗︎

0

151

3

0

0

Details:

PR feedback
Project: Cloud Manager E2E	Commit: c7bb561bf5
Status: Passed	Duration: 13:58 💡
Started: Apr 26, 2023 5:16 PM	Ended: Apr 26, 2023 5:30 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[dwiley-akamai]

Curious as to what made this break out of nowhere 🤔

[hkhalil-akamai]

Curious as to what made this break out of nowhere 🤔

It appears to be related to API ticket ARB-3629. The interface was modified to add the id field but the docs have not been updated.

[hkhalil-akamai]

Tested to confirm the fix is working as intended.

Approved pending api-v4 suggestion by @bnussman-akamai.

[bnussman-akamai]

I think the next steps for this PR would to be to update the api-v4 types like the following

export interface Interface {
  id: number;
  label: string | null;
  purpose: InterfacePurpose;
  ipam_address: string | null;
}

type InterfacePayload = Omit<Interface, 'id'>;

Then update LinodeConfigCreationData to use InterfacePayload

[cpathipa]

Great feedback! Thank you @bnussman-akamai and @hkhalil-akamai for taking a deeper look into this PR.