style: [M3-6030] - Adjust banner text size and spacing to improve readability #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #3252 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
bnussman-akamai
approved these changes
Apr 28, 2023
This was referenced May 15, 2023
cpathipa
added a commit
that referenced
this pull request
May 30, 2023
* feat: [M3-5915] Accessible graph data (#9045) * fix: [M3-5915] - initial commit for new component * feat: [M3-5915] - initial commit for new component * fix: [M3-5915] - dynamic rendering based on filters * fix: [M3-5915] - markup, comments, styles & cleanup * fix: [M3-5915] - improve canvas accessibility tags * fix: [M3-5915] - accessible units for new chart data table * feat: [M3-5915] - add aria-describedby * feat: [M3-5915] - safeguards * feat: [M3-5915] - changelo update * feat: [M3-5915] - safer ID * feat: [M3-5915] - add test * feat: [M3-5915] - address feedback * feat: [M3-5915] - address feedback 2 * feat: [M3-5915] - address feedback 3 * feat: [M3-5915] - update storybook * feat: [M3-5915] - code cleanup * feat: [M3-5915] - prevent malformed value data * feat: [M3-5915] - address feedback * fix: [M3-6454] - Show error for PayPal payments * feat: [M3-6525] - Storybook config cleanup (#9055) * feat: [M3-6525] - initial commit * feat: [M3-6525] - fix build errors * feat: [M3-6525] - move fonts outside of public dir * feat: [M3-6525] - more config cleanup * feat: [M3-6525] - revert font move * chore: [M3-6496] - Add Adobe Analytics custom event tracking (#9004) * Add AA launch scripts and DCR on tracked events * Update satellite.track function to use generic, single identifier * Update launch script src assignment with logic for additional envs * Use a single env var from Jenkins * Disable tracking on custom events in Adobe for now * Cleanup * Enable direct call rule for AA custom event tracking * Add AA launch scripts and DCR on tracked events * Update satellite.track function to use generic, single identifier * Update launch script src assignment with logic for additional envs * Use a single env var from Jenkins * Disable tracking on custom events in Adobe for now * Cleanup * Only append Adobe Analytics script with valid url * Prevent errors if AA env is not defined * Update sendEvent * Test if loadScript works instead * Revert previous commit to move location of script * Log error when sendEvent fails * refactor: [M3-6306] - MUI v5 Migration SRC > Components > CopyableTextField (#9018) * refactor: [M3-6306] - SRC > Components > CopyableTextField * PR feedback * resolve specificity * Update styling * refactor styles using styled * Update CHANGELOG.md * refactor: [M3-6320] - MUI v5 Migration - Components > DialogTitle (#9050) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * fix: [M3-5852] - Phone Verification - Verification Code State Does Not Reset (#9059) * reset the code mutation whenever the user sends a code to their phone * reset code input on Enter Different Phone Number --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: Prepare for React Query for Linodes (#9049) - Does some preliminary moving around of some code to prepare for React Query for Linodes - Updates React Query for Volumes to use our new query key pattern - Sets up Linode RQ event handler so we can have peace of mind that RQ is up to date --------- Co-authored-by: Banks Nussman <banks@nussman.us> * feat: [M3-6525] - Storybook story POC (#9060) * feat: [M3-6525] - initial commit * feat: [M3-6525] - move fonts outside of public dir * feat: [M3-6525] - more config cleanup * feat: [M3-6525] - revert font move * feat: [M3-6526] - initial commit * refactor: [M3-6217] - Refactor Domains E2E Test Intercepts (#9057) * style: [M3-6030] - Adjust banner text size and spacing to improve readability (#9064) * Remove Notice inner p fontSize of 16px (1rem) * Removed commented code * Define lineHeight * Add changelog entry; add forgotten changelog entry * test: [M3-6052] - Add LKE cluster update and delete integration tests (#9054) * Add LKE mock utilities * Add LKE deletion integration tests * Add LKE landing page integration tests * Add Cypress downloaded file utils * Add LKE update integration tests * Add QA data attributes for node pool sections * Add QA data attributes for node pool rows * Add Kubernetes dashboard response factory * Dismiss LKE node recycle dialog upon confirmation * chore: Update changelog with unreleased section (#9074) * fix: [M3-6022] - Add compression to logo when rendering in JPG format during invoice PDF generation #9069 * fix: add compression to logo when rendering in JPG format during PDF generation * Update changelog --------- Co-authored-by: mjac0bs <mjacobs@akamai.com> Co-authored-by: Richie McIntosh <93939013+richardmcintosh@users.noreply.github.com> * fix: [M3-6540] - Surface general errors in the Object Storage Bucket Create Drawer (#9067) Surfaces any general errors as a notice in the Object Storage Create Bucket drawer Previously, only errors specific to the label and region would show --------- Co-authored-by: Banks Nussman <banks@nussman.us> * feat: [M3-6464] – Add resource links to empty Volumes landing page (#9065) * feat: [M3-6520] - Add new flag to deliver DC availability notice for premium plans (#9066) * feat: [M3-6520] - Add new flag to deliver DC availability notice for premium plans * feat: [M3-6520] - Move to new component for reusability * feat: [M3-6520] - feedback * refactor: [M3-6484] - React Query Linodes - Linodes Landing (#9062) - Uses API pagination and sorting on the Linodes Landing page - Made the CSV download actually contain useful information - Removed the group by tag and card views --------- Co-authored-by: Banks Nussman <banks@nussman.us> * feat: [M3-5655] - Allow user to download DNS zone file (#9075) * feat: [M3-5655] - Allow user to download DNS zone file * PR feedback - use util function downloadFile * PR -feedback * code cleanup * Added test coverage * Update packages/manager/src/features/Domains/DownloadDNSZoneFileButton.tsx Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> * UX - Change and feedback * Code cleanup - use import instead of require --------- Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> * fix: [M3-6558] - Remove 'MongoDB' from ClusterControl description in Marketplace (#9081) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * fix: [M3-5088] - Allow simple search for IPv6 addresses (#9073) * fix: [M3-5088] - Add field search skipping rules * fix: [M3-5088] - Add comments * Changelogs for Cloud v1.92.0, JS Client v0.91.0, and Validation package v0.23.0 * fix: [M3-5088] - Renaming things * fix: [M3-5088] - Use better matching * fix: [M3-5088] - Cleanup * fix: [M3-5088] - Changelog * fix: [M3-5088] - minor feedback --------- Co-authored-by: Banks Nussman <banks@nussman.us> * fix: [M3-6509] Enable Cypress's experimental memory management config (#9076) * M3-6222: Refactor Images E2E Test Intercepts (#9080) * refactor: [M3-6400, M3-6401, M3-6404, M3-6408] - MUI v5 Migration - Components > Table, TableBody, TableHead, TableCell, TableSortCell, TableRow (#9082) MUI v5 Migration for most Table related components --------- Co-authored-by: Banks Nussman <banks@nussman.us> * feat: [M3-6465] Empty Firewall Landing Page Resources & Resources Abstraction (#9078) * feat: [M3-6465] saving progress * feat: [M3-6465] saving progress * feat: [M3-6465] improve API & compose page * feat: [M3-6465] Data & cleanup * feat: [M3-6465] fix for external icons * feat: [M3-6465] more cleanup * feat: [M3-6465] changelog entry * feat: [M3-6465] fix wrong link * feat: [M3-6465] convert ResourcesLinksSection to styled component * feat: [M3-6465] Address feedback - part 2 * feat: [M3-6465] Address feedback - part 3 * feat: [M3-6465] Address feedback - part 4 * feat: [M3-6465] Address feedback - part 5 * feat: [M3-6465] Cleanup and reusability * feat: [M3-6465] Abstract resource section * feat: [M3-6465] fixing icons on linodes, k8s and DBs * feat: [M3-6465] Final cleanup * chore: Upgrade Cypress to v12.11 (#9038) * Upgrade Cypress to v12.11 * Upgrade Cypress related dependencies * Update cached data * fix: Linode Details Access Table UI (#9085) Fixes UI regression in the Linode Details Entity Header access table caused by refactor: [M3-6400, M3-6401, M3-6404, M3-6408] - MUI v5 Migration - Components > Table, TableBody, TableHead, TableCell, TableSortCell, TableRow #9082 Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6492, M3-6315] - React Query - Linode Detail - Backups (#9079) - React Query for Linode Backups 🚀 - Modernizes the Linode Backups section of the Linodes Details page - Breaks up Backup related code into more components with more understandable names - Adds `available` to the LinodeBackup type because it was missing - Resolves Sentry errors caused by this section of the app (M3-6315) - Makes some minor UI and UX improvements 🎨 --------- Co-authored-by: Banks Nussman <banks@nussman.us> * change: [M3-6483] – Update OCAs highlighted on empty state Linodes landing page (#9083) * feat: [M3-6467] - Add resource links to Domains empty state landing page (#9092) * feat: [M3-6467] - Add resource links to Domains empty state landing page * Update CHANGELOG.md * change: [M3-6465] - Move linodes, k8s & dbs empty landing pages resources to HOC (#9088) * change: [M3-6465] move k8 empty landing page to POC * change: [M3-6465] move db empty landing page to POC * change: [M3-6465] fix db test * change: [M3-6465] move linodes empty landing page to POC * change: [M3-6465] add missing external icons * change: [M3-6465] cleanup and styling * change: [M3-6465] more cleanup and styling * refactor: [M3-6366] - MUI v5 - Components/Notice (#9094) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * refactor: [M3-6326] - MUI v5 - Components > DownloadCSV (#9084) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * refactor: [M3-6390] - MUI v5 - Components/ShowMoreExpansion (#9096) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6301] – `MUI v5 - Components > CheckoutSummary` (#9100) * refactor: [M3-6376] – `MUI v5 - Components > PrimaryNav` (#9090) * feat: [M3-6470] - Add resource links to StackScripts empty state landing state (#9091) * feat: [M3-6470] - Add resource links to StackScripts empty state landing page * Add StackScriptsIcon * Update CHANGELOG.md * Update right doc url for Shell Scripts * PR: feedback organize imports * PR: Feedback * Update youtube link for Shell Scripts Explained * change: [M3-6057] - Avoid saving/uploading Cypress recordings for successful specs in CI * refactor: [M3-6347] – MUI v5 - Components > IconButton (#9102) Style migration for <IconButton />, Removes any "wrapping" to the <IconButton /> because it was not needed --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: M3-6489: React Query Linode Details - Network Tab (#9097) React Query-ifys most things under the Linode Details Network Tab --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6488] - React Query for Linode Details - General Details (#9099) Switches the "top half" of the Linodes details page to use React Query --------- Co-authored-by: Banks Nussman <banks@nussman.us> * feat: [M3-6466] Add resource links to Images empty state (#9095) * feat: [M3-6466] Add resource links to Images empty state * feat: [M3-6466] Add changelog entry * feat: [M3-6467] - Add resource links to Domains empty state landing page (#9092) * feat: [M3-6467] - Add resource links to Domains empty state landing page * Update CHANGELOG.md * feat: [M3-6466] Add changelog entry * feat: [M3-6466] fix dupe changelo entry * feat: [M3-6466] feedback: responsive change * feat: [M3-6466] feedback: responsive change --------- Co-authored-by: cpathipa <119517080+cpathipa@users.noreply.github.com> * feat: [M3-6468] Add resource links to Object Storage empty state (#9098) * feat: [M3-6468] Add resource links to Object Storage empty state * feat: [M3-6468] Add changelog entry * feat: [M3-6468] Fix smoke test * feat: [M3-6468] Fix e2e suite * feat: [M3-6468] Fix access keys header display and associated tests * feat: [M3-6468] Icon and cleanup * feat: [M3-6468] missing icon file * feat: [M3-6468] generate mocked keys from utility * feat: [M3-6468] address feedback * feat: [M3-6468] address feedback: migrate LandingHeader from legacy grid * chore: Clean up `App.tsx` and `MainContent.tsx` (#9106) fixes useless whitespace in the HTML, removes unused styles, removes unused props --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6334] - MUI v5 - Components > EntityHeader (#9109) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * fix: [M3-5768] - Verify bug still exists * chore: [m3-6511] Changelog Automation (#9104) * chore: [m3-6511] initial commit * chore: [m3-6511] Wrap up changeset generation script * chore: [m3-6511] Some cleanup * chore: [m3-6511] Wrap up changelog generation script * chore: [m3-6511] cleanup * chore: [m3-6511] formatting, try catch blocks, sorting * chore: [m3-6511] delete job * chore: [m3-6511] semver prompt * chore: [m3-6511] cleanup part 1 * chore: [m3-6511] cleanup part 2 * chore: [m3-6511] Adding contribution guide * chore: [m3-6511] feedback * feat: [M3-6511] better file naming convention * feat: [M3-6511] fix commit step * feat: [M3-6511] Address feedback 1 * feat: [M3-6511] Address feedback 2 * feat: [M3-6511] Address feedback 3 * test: [M3-6550] - Add Domain delete, import a zone, and download zone file Cypress tests (#9111) * M3-6550: Add new Domain tests * Fix comments * refactor: [M3-6569] - React Query for Support Tickets - Ticket Details (#9105) * initial refactor * clean up and make mutation for close button * do some basic unit testing * fix e2e test not accounting for params * re-add `React.memo` to `ExpandableTicketPanel` * use tss for `CloseTicketLink` * feedback @dwiley-akamai * feedback @abailly-akamai --------- Co-authored-by: Banks Nussman <banks@nussman.us> * Revert - CreateIPv4Drawer should be deleted * fix: [M3-6578] Regression with create flow header doc link (#9122) * chore: [M3-6582] - Changeset description and bug fix (#9132) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * refactor: [M3-6420] – `MUI v5 - Components > TransferDisplay` (#9107) * refactor: [M3-6246] - SRC > Features > CancelLanding (#9113) * refactor: [M3-6246] - SRC > Features > CancelLanding * code cleanup * refactor: [M3-6374, M3-6344] - MUI v5 Migration - `Components > Placeholder & H1Header` (#9131) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * fix: [M3-6581] - Fix Cloud Manager Maintenance Mode (#9130) ensure we mark feature flags as loaded even if we can't load API data --------- Co-authored-by: Banks Nussman <banks@nussman.us> * fix: [M3-5783] Firewall Rules - Improve form requirements and feedback (#9127) * fix: [M3-5783] Feature Cleanup * fix: [M3-5783] Feature Cleanup 2 * fix: [M3-5783] Improve form requirements and feedback * fix: [M3-5783] Fix tests * Add changeset * fix conflicts * fix conflicts * removed unused code that I missed in conflicts * use proper mutation handlers * refactor: [M3-6333] - MUI v5 Migration - `Components > EntityDetail` (#9123) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * refactor: [M3-6329] - MUI v5 Migration - `Components > EditableEntityLabel` (#9129) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * refactor: [M3-6337] - MUI v5 Migration - `Components > ErrorState` (#9128) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * change: [OCA-1137] - deprecate unifi marketplace app (#9145) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Hana Xu <hxu@akamai.com> * ci: [M3-6566] - Update container environment variables for Cypress 12.3 changes (#9089) * Restore CYPRESS_PULL_REQUEST_* vars * Document Cypress Docker container environment vars * Use YAML anchors/aliases to reduce redundancy * Remove unneeded and undefined Jenkins version environment variable * chore: Remove unused Linode components (#9155) * remove unused linodes files * remove more unused components * remove old comment --------- Co-authored-by: Banks Nussman <banks@nussman.us> * refactor: [M3-6421 & M3-6422] – MUI v5 Migration - `Components > TypeToConfirm` & `Components > TypeToConfirmDialog` (#9124) * refactor: [M3-6423] - Remove unused ViewAllLink and ActivitySummary (#9154) ## Description 📝 The original ask was to migrate the styles in the `ViewAllLink` component but the component it was used in (`ActivitySummary`) wasn't being used as far as I could tell. And the Linode detail activity seems to be populated in the `LinodeActivity` component ## How to test 🧪 Check that removing ActivitySummary and ActivitySummaryContent didn't cause any regressions * change: [M3-5963] - Update Marketplace analytics search event (#9141) * refactor: [M3-6335] - MUI v5 Migration - `Components > EntityIcon` (#9125) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * fix: [M3-6622] - Fix Dialog Title Close Button Color (#9160) This PR sets the color of the close button in the Dialog title to primary to make it match production --------- Co-authored-by: Banks Nussman <banks@nussman.us> * Tech Story [M3-6276]: Nodebalancers MUI Migration (#9139) * Refactor: [M3-6276]: ConfigNodeIPSelect * Refactor: [M3-6276]: NodeBalancerConfigNode * Refactor: [M3-6276]: NodeBalancerConfigPanel * Refactor: [M3-6276]: NodeBalancerSummary * Refactor: [M3-6276]: NodeBalancerLandingEmpty * Refactor: [M3-6276]: NodeBalancerConfigurations * Refactor: [M3-6276]: SummaryPanel * Refactor: [M3-6276]: TablesPanel * Added changeset: Nodebalancers (feature) MUI Migration * Refactor: [M3-6276]: Address feedback * Chore: [M3-6511] Changeset BOT (#9137) * Feat m3 6511 bot squash (#1) * chore: [m3-6511] initial commit * chore: [m3-6511] Wrap up changeset generation script * chore: [m3-6511] Some cleanup * chore: [m3-6511] Wrap up changelog generation script * chore: [m3-6511] cleanup * chore: [m3-6511] semver prompt * chore: [m3-6511] cleanup part 1 * chore: [m3-6511] cleanup part 2 * chore: [m3-6511] Adding contribution guide * chore: [m3-6511] feedback * feat: [M3-6511] Initial bot commit * feat: [M3-6511] find PR changeset script * Add changeset * feat: [M3-6511] clean up old data * feat: [M3-6511] save progress with commenting script * feat: [M3-6511] save progress with commenting script 2 * feat: [M3-6511] Post rebase fix * feat: [M3-6511] dotenv update * feat: [M3-6511] dotenv update * feat: [M3-6511] workflow and cleanup * feat: [M3-6511] more cleanup * feat: [M3-6511] new workflow node V * feat: [M3-6511] new workflow node V * feat: [M3-6511] workflow update 1 * feat: [M3-6511] workflow update 2 * feat: [M3-6511] workflow update 3 * feat: [M3-6511] workflow update 4 * feat: [M3-6511] debug 1 * feat: [M3-6511] debug 2 * feat: [M3-6511] debug 3 * feat: [M3-6511] debug 4 * feat: [M3-6511] debug 5 * feat: [M3-6511] debug 6 * feat: [M3-6511] debug 7 * feat: [M3-6511] debug 8 * feat: [M3-6511] debug 9 * feat: [M3-6511] debug 10 * feat: [M3-6511] debug 11 * feat: [M3-6511] debug 12 * feat: [M3-6511] debug 13 * feat: [M3-6511] debug 14 * feat: [M3-6511] debug 15 * feat: [M3-6511] debug 16 * feat: [M3-6511] debug 17 * feat: [M3-6511] debug 18 * feat: [M3-6511] debug 19 * feat: [M3-6511] debug 20 * feat: [M3-6511] debug 21 * feat: [M3-6511] debug 22 * feat: [M3-6511] debug 23 * feat: [M3-6511] debug 24 * feat: [M3-6511] disable ci temporarily * feat: [M3-6511] debug 25 * feat: [M3-6511] debug 26 * feat: [M3-6511] debug 27 * feat: [M3-6511] debug 28 * feat: [M3-6511] debug 29 * feat: [M3-6511] debug 30 * feat: [M3-6511] cleanup * feat: [M3-6511] more cleanup * feat: [M3-6511] final cleanup * Added changeset: Changeset bot to remind contributors to include a changeset when needed * feat: [M3-6511] Post rebase fix * Update packages/manager/scripts/changelog/compiled/README.md Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> --------- Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * refactor: [M3-6493] - React Query - Linode Detail - Settings Tab (#9121) * react query-ify linode settings components * clean up exports * add basic testing for `<LinodeSettingsLabelPanel />` * improve the `<LinodeSettingsLabelPanel />` test * remove unneeded restricted user logic * Added changeset: React Query for Linode Details Settings Tab --------- Co-authored-by: Banks Nussman <banks@nussman.us> * fix: [M3-5768] - * refactor: [M3-6331] - MUI v5 - `Components > EnhancedNumberInput` (#9152) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> * Chore: [M3-6511]: Fix Albot (#9166) * Chore: [M3-6511]: Fixing Albot part 1 * Chore: [M3-6511]: Fixing Albot part 2 * Chore: [M3-6511]: Fixing Albot part 3 * Chore: [M3-6511]: Fixing Albot part 4 * Chore: [M3-6511]: Fixing Albot part 5 * Chore: [M3-6511]: Fixing Albot part 6 * chore: Organize files under `src/foundations/` (#9157) Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> * Chore: [M3-6511]: Goodbye for now, Albot (#9170) * Chore: [M3-6511]: Goodbye for now, Albot * Chore: [M3-6511]: Remove associated changeset * Refactor: [M3-6277] Notification center MUI Migration (#9162) * add changelog entry * Refactor: [M3-6277]: RenderEvent & RenderProgressEvent * Refactor: [M3-6277]: useFormattedNotifications * Refactor: [M3-6277]: cleanup and commenting * Refactor: [M3-6277]: NotificationSection * Refactor: [M3-6277]: Small styling fixes * Rebase fix * Refactor: [M3-6277]: Adjust styles * Refactor: [M3-6277]: Address feedback * Refactor: [M3-6277]: Address feedback 2 * Refactor: [M3-6277]: Address feedback 3 --------- Co-authored-by: Banks Nussman <banks@nussman.us> * fix: [M3-6586] - Improve error handing for loadScript and Adobe Analytics (#9161) * Remove exception logged when AA custom event cannot fire * Return a promise from loadScript * Update check in resolved promise * Add changeset * Define constant for Adobe script number * Address feedback * Changelogs for Cloud v1.94.0 and JS Client v0.93.0 * Cloud version 1.94.0, API v4 version 0.23.0 * Update changelog * Delete changeset, update api-v4 change log release date --------- Co-authored-by: Alban Bailly <130582365+abailly-akamai@users.noreply.github.com> Co-authored-by: ecarrill <ecarrill@akamai.com> Co-authored-by: Mariah Jacobs <114685994+mjac0bs@users.noreply.github.com> Co-authored-by: Jaalah Ramos <125309814+jaalah-akamai@users.noreply.github.com> Co-authored-by: Jaalah Ramos <jaalah.ramos@gmail.com> Co-authored-by: carrillo-erik <119514965+carrillo-erik@users.noreply.github.com> Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com> Co-authored-by: Banks Nussman <banks@nussman.us> Co-authored-by: cliu-akamai <126020611+cliu-akamai@users.noreply.github.com> Co-authored-by: jdamore-linode <97627410+jdamore-linode@users.noreply.github.com> Co-authored-by: rmcintosh <rmcintosh@users.noreply.github.com> Co-authored-by: mjac0bs <mjacobs@akamai.com> Co-authored-by: Richie McIntosh <93939013+richardmcintosh@users.noreply.github.com> Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> Co-authored-by: tbaka <48444023+tbaka@users.noreply.github.com> Co-authored-by: Hana Xu <hxu@akamai.com> Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Our current banner text is too large and cramped. To improve readability, we'll change text size of body text to
14px(or equivalent) and line height to20px. Blue banner title can remain current size.These requirements should apply to:
...all of which rely on the
DismissibleBannercomponent, which uses theNoticecomponent under the hood.Major Changes 🔄
List highlighting major changes
ptag of theNoticecomponent, which was overwriting existing styling offontSize: 0.875rem(14px).DismissibleBanner.tsx. Existing Typography styling was applying a default lineHeight of1.125rem(18px).Preview 📷
How to test 🧪
developlocally and turn on the MSW.0.875remand line height1.25rem,that is not being overwritten by other styles.Notice, without a Banner, remains consistent with prod. (A couple places to check: SMTPRestrictionNotice in http://localhost:3000/linodes/{id} or https://cloud.linode.com/kubernetes/create by adding a node pool with <3 linodes.)