staging → master for v1.92.0

CHANGELOG.md

@@ -4,6 +4,58 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2023-05-01] - v1.92.0
+
+### Added:
+- No Results section for Marketplace Search #8999
+- Private IP checkbox when cloning a Linode #9039
+- Metadata migrate warning #9033
+
+### Changed:
+- Region Select will dynamically get country flags and group all countries based on API data #8996
+- Removed MongoDB Marketplace Apps #9071
+
+### Fixed:
+- Kubernetes Delete Dialog clears when it is re-opened #9000
+- HTML showing up in event messages #9003
+- Inability to edit and save Linode Configurations #9053
+- Marketplace One Click Cluster UDF caching issue #8997
+- Prevent IP transfer & sharing modals form submission if no action selected #9026
+- Increase radio button padding to fix hover effect shape #9031
+- Blank Kubernetes Node Pool plan selection #9009
+
+### Tech Stories:
+- MUI v5 Migration - `Components > CircleProgress` #9028
+- MUI v5 Migration - `Components > StatusIcon` #9014
+- MUI v5 Migration - `Components > TagsInput, TagsPanel` #8995
+- MUI v5 Migration - Grid v2 for Features #8985
+- MUI v5 Migration - `Components > Dialog` #9020
+- MUI v5 Migration - `Components > DeletionDialog` #9047
+- MUI v5 Migration - `Components > Currency` #9030
+- MUI v5 Migration - `Components > DisplayPrice` #9022
+- MUI v5 Migration - `Components > CreateLinodeDisabled` #9015
+- MUI v5 Migration - `Components > DateTimeDisplay, DebouncedSearchTextField` #9007
+- MUI v5 Migration - `Components > ConfirmationDialog` #9016
+- MUI v5 Migration - `Components > CopyTooltip` #9040
+- MUI v5 Migration - `Components > CheckoutBar` #9051
+- MUI v5 Migration - `Components > CreateLinodeDisabled` #9015
+- MUI v5 Migration - `Components > ColorPalette` #9013
+- MUI v5 Migration - `Components > Tile` #9001
+- MUI v5 Migration - `Components > TagsInput, TagsPanel` #8995
+- MUI v5 Migration - `Components > DismissibleBanner` #8998
+- MUI v5 Migration - `Components > SupportLink, TextTooltip` #8993
+- MUI v5 Migration - `Components > Toggle` #8990
+- MUI v5 Migration - `Components > SplashScreen` #8994
+- Remove `ConditionalWrapper` #9002
+- Upgrade New Relic to v1230 #9005
+- Add basic Adobe Analytics tracking #8989
+- Add more eslint rules #9043
+- @linode/validation version badge Label in `README.md` #9011
+- Improve Firewall ports regex to prevent exponential backtracking #9010
+- Fix code scanning alert that DOM text is reinterpreted as HTML #9032
+- Fix the typesafety of the `<Select />` component #8986
+- Update PayPal and Braintree dependencies #9052
+
 ## [2023-04-18] - v1.91.1
 
 ### Fixed:
@@ -44,10 +96,12 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 ## [2023-04-03] - v1.90.0
 
 ### Added:
+
 - Delete warning to LKE [#8891](https://github.com/linode/manager/pull/8891)
 - “to another region” to the title of the Linode Migrate Dialog [#8920](https://github.com/linode/manager/pull/8920)
 
 ### Changed:
+
 - Disable Download CA Certificate when DB is provisioning [#8890](https://github.com/linode/manager/pull/8890)
 - Update OCC logos to include naming convention [#8927](https://github.com/linode/manager/pull/8927)
 - MUI v5 Migration - Features > Billing [#8895](https://github.com/linode/manager/pull/8895)
@@ -65,29 +119,35 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 - React Query for Notifications [#8915](https://github.com/linode/manager/pull/8915)
 
 ### Fixed:
+
 - Filtering by `Status` on Linode Details Volumes Table [#8947](https://github.com/linode/manager/pull/8947)
 - Tag drawer in LinodesLanding summary view [#8909](https://github.com/linode/manager/pull/8909)
 - Crash for Events with a `null` community post `entity` [#8912](https://github.com/linode/manager/pull/8912)
 - Incorrect headline in Linode Details Networking table [#8925](https://github.com/linode/manager/pull/8925)
+- One Click Cluster UDF Caching issue [#8997](https://github.com/linode/manager/pull/8997)
 
 ### Removed:
+
 - Repo clean up, remove old Redux Docs [#8907](https://github.com/linode/manager/pull/8907)
 
 ## [2023-03-28] - v1.89.1
 
 ### Fixed:
+
 - NodeBalancer Configurations not saving [#8929](https://github.com/linode/manager/pull/8929)
 
 ## [2023-03-20] - v1.89.0
 
 ### Added:
+
 - One Click Clusters [#8878](​​https://github.com/linode/manager/pull/8878)
 - Infinitely Loaded Volume Select [#8876](https://github.com/linode/manager/pull/8876)
 - Allow users to select `system` as a theme option [#8869](https://github.com/linode/manager/pull/8869)
 - Vite [#8838](https://github.com/linode/manager/pull/8838)
 - Resource links to Kubernetes empty state landing page [#8827](https://github.com/linode/manager/pull/8827)
 
 ### Changed:
+
 - Updated maintenance and account activation screen logo [#8879](https://github.com/linode/manager/pull/8879)
 - Updated `VolumeStatus` type and logic [#8862](https://github.com/linode/manager/pull/8862)
 - Temporarily changed Remit To invoice address [#8847](https://github.com/linode/manager/pull/8847)
@@ -97,26 +157,31 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 - Use region `label` from `/v4/regions` instead of `dcDisplayNames` constant [#8851](https://github.com/linode/manager/pull/8851)
 
 ### Fixed:
+
 - Use our custom dialog for Monthly Network Transfer Pool instead of MUI's [#8874](https://github.com/linode/manager/pull/8874)
 - Radio Styles after Vite Upgrade [#8871](https://github.com/linode/manager/pull/8871)
 - Disable/hide showAll for PaginationFooter [#8826](https://github.com/linode/manager/pull/8826)
 - Invalidate Firewall devices cache when a Linode is deleted [#8848](https://github.com/linode/manager/pull/8848)
 
 ### Removed:
+
 - VLANs from Redux [#8872](https://github.com/linode/manager/pull/8872)
 - Unused packages + update lint-staged [#8860](https://github.com/linode/manager/pull/8860)
 - /core/styles abstraction for tss-react codemod [#8875](https://github.com/linode/manager/pull/8875)
 
 ## [2023-03-06] - v1.88.0
 
 ### Breaking:
+
 - Remove deprecated `ip_whitelist_enabled` Profile Toggle
 
 ### Added:
+
 - Support for local development access from local domain
 - Account Logins Show `Successful` or `Failed` Access
 
 ### Changed:
+
 - Increased minimum acceptable password strength for Linode root passwords
 - Use React Query to fetch and store user preferences, tags, and images
 - Use `URLSearchParams` to standardize query string parsing and stringifying
@@ -126,47 +191,57 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) and this p
 - Use Region ID to dynamically generate LISH URLs
 
 ### Removed:
+
 - `wait-on` package for CVE-2023-25166
 
 ### Fixed:
+
 - Firewall Rules Table rendering overlapping text
 - `validateDOMNesting` warning in console
 
 ## [2023-02-21] - v1.87.0
 
 ### Added:
+
 - Ability to create Object Storage folders
 
 ### Changed:
+
 - Standardize Text tooltip
 - Prevent Firewall Rule Drawer reset if the same preset is reselected
 
 ## [2023-02-13] - v1.86.0
 
 ### Added:
+
 - “Status” column to Linode Backups table
 
 ### Changed:
+
 - Migrate to Material UI v5 theme format
 - Accessibility improvements to TopMenu icons
 - Logo updates
 - Account Agreements Query Small Optimization
 
 ### Fixed:
+
 - Uneven Breakpoints in Kubernetes Landing Table
 
 ## [2023-02-07] - v1.85.0
 
 ### Added:
+
 - Databases as a User Permissions Option
 - Monthly Network Transfer Pool to select empty state landing pages
 - API/CLI usage information to Linode Create
 
 ### Changed:
+
 - Improve firewall rule list screen reader support
 - UX copy for “Getting Started” playlists
 
 ### Fixed:
+
 - API Tokens revocation
 
 ## [2023-01-18] - v1.84.0

README.md

@@ -27,7 +27,7 @@
     <img alt="api-v4 bundle size" src="https://img.shields.io/bundlephobia/min/@linode/api-v4?label=api-v4 size">
   </a>
   <a href="https://www.npmjs.com/package/@linode/validation">
-    <img src="https://img.shields.io/npm/v/@linode/validation?label=%40linode%2Fapi-v4" alt="@linode/validation version" />
+    <img src="https://img.shields.io/npm/v/@linode/validation?label=%40linode%2Fvalidation" alt="@linode/validation version" />
   </a>
   <a href="https://bundlephobia.com/package/@linode/validation">
     <img alt="validation bundle size" src="https://img.shields.io/bundlephobia/min/@linode/validation?label=validation size">

docs/PULL_REQUEST_TEMPLATE.md

@@ -1,36 +1,45 @@
 ## Description 📝
+**Brief description explaining the purpose of the changes**
 
-**What does this PR do?**
+## Major Changes 🔄
+**List highlighting major changes**
+- Change #1
+- Change #2
 
 ## Preview 📷
+**Include a screenshot or screen recording of the change**
 
-**Remove this section or include a screenshot or screen recording of the change**
+> **Note**: Use `<video src="" />` tag when including recordings in table
 
-## How to test 🧪
-
-**What are the steps to reproduce the issue or verify the changes?**
+| Before  | After   |
+| ------- | ------- |
+| Content | Content |
 
-**How do I run relevant unit or e2e tests?**
+## How to test 🧪
+1. **How to setup test environment?**
+2. **How to reproduce the issue (if applicable)?**
+3. **How to verify changes?**
+4. **How to run Unit or E2E tests?**
 
 ## Commit message and pull request title format standards
 
-**Remove this section before opening the pull request**
+> **Note**: Remove this section before opening the pull request
 
 **Make sure your PR title and commit message on squash and merge are as shown below**
 
 `<commit type>: [JIRA-ticket-number] - <description>`
 
-**commit types:**  
-`feat`: New feature for the user (not a part of the code, or ci, ...).  
-`fix`: Bugfix for the user (not a fix to build something, ...).  
-`refactor`: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.  
-`style`: General styling changes. Does not change any functionality.  
-`build`: Changes to the application build.  
-`chore`: Other changes that do not impact production code.  
-`ci`: Changes to the CI pipeline.  
-`docs`: Changes to the documentation docs.  
-`perf`: Performance changes.  
-`test`: New tests or changes to existing tests. Does not change the production code.  
-`change`: Only use for something that doesn’t fit in any other category.  
+**Commit Types:**
+- `feat`: New feature for the user (not a part of the code, or ci, ...).
+- `fix`: Bugfix for the user (not a fix to build something, ...).
+- `refactor`: Restructuring existing code without changing its external behavior or visual UI. Typically to improve readability, maintainability, and performance.
+- `style`: General styling changes. Does not change any functionality.
+- `build`: Changes to the application build.
+- `chore`: Other changes that do not impact production code.
+- `ci`: Changes to the CI pipeline.
+- `docs`: Changes to the documentation docs.
+- `perf`: Performance changes.
+- `test`: New tests or changes to existing tests. Does not change the production code.
+- `change`: Only use for something that doesn’t fit in any other category.
 
 **Example:** `feat: [M3-1234] - Allow user to view their login history`

package.json

@@ -58,8 +58,7 @@
     "minimatch": "^3.0.5",
     "nth-check": "^2.0.1",
     "@types/react": "^17",
-    "loader-utils": "^2.0.4",
-    "@braintree/sanitize-url": "^6.0.2"
+    "loader-utils": "^2.0.4"
   },
   "workspaces": {
     "packages": [

packages/api-v4/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [2023-05-01] - v0.91.0
+
+### Added:
+- `InterfacePayload` type for network interface data when creating a Linode or a Linode configuration #9053
+- `id` to the `Interface` type #9053
 
 ## [2023-04-17] - v0.90.0
 

packages/api-v4/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@linode/api-v4",
-  "version": "0.90.0",
+  "version": "0.91.0",
   "homepage": "https://github.com/linode/manager/tree/develop/packages/api-v4",
   "bugs": {
     "url": "https://github.com/linode/manager/issues"
@@ -70,7 +70,7 @@
     "jest": "~26.4.2",
     "lint-staged": "^13.2.0",
     "prettier": "~2.2.1",
-    "tsup": "^6.6.3"
+    "tsup": "^6.7.0"
   },
   "resolutions": {
     "handlebars": "^4.4.3"

packages/api-v4/src/firewalls/types.ts

@@ -24,8 +24,8 @@ export interface FirewallRules {
 }
 
 export interface FirewallRuleType {
-  label?: string;
-  description?: string;
+  label?: string | null;
+  description?: string | null;
   protocol: FirewallRuleProtocol;
   ports?: string;
   action: FirewallPolicyType;

packages/api-v4/src/linodes/types.ts

@@ -149,10 +149,14 @@ export type LinodeStatus =
 export type InterfacePurpose = 'public' | 'vlan';
 
 export interface Interface {
+  id: number;
   label: string | null;
   purpose: InterfacePurpose;
   ipam_address: string | null;
 }
+
+export type InterfacePayload = Omit<Interface, 'id'>;
+
 export interface Config {
   id: number;
   kernel: string;
@@ -261,7 +265,7 @@ export interface LinodeConfigCreationData {
     devtmpfs_automount: boolean;
   };
   root_device: string;
-  interfaces?: Interface[];
+  interfaces?: InterfacePayload[];
 }
 
 export interface PriceObject {

packages/manager/.env.example

@@ -20,6 +20,9 @@ REACT_APP_LKE_HIGH_AVAILABILITY_PRICE='60'
 # Error monitoring with Sentry:
 # REACT_APP_SENTRY_URL=
 
+# Adobe Analytics:
+# REACT_APP_ADOBE_ANALYTICS_URL=
+
 # Google Analytics:
 # REACT_APP_GA_ID=
 

packages/manager/.eslintrc.js

@@ -95,6 +95,8 @@ module.exports = {
     '@typescript-eslint/explicit-module-boundary-types': 'off',
     // react and jsx specific rules
     'react/display-name': 'off',
+    'react-hooks/rules-of-hooks': 'error',
+    'react-hooks/exhaustive-deps': 'warn',
     // requires the definition of proptypes for react components
     'react/prop-types': 'off',
     'react/jsx-no-script-url': 'error',