-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-6063] - Refactor components to use TypeToConfirmDialog component #9175
Conversation
3 flaky tests on run #4714 ↗︎
Details:
linodes/linode-storage.spec.ts • 1 flaky test
stackscripts/create-stackscripts.spec.ts • 1 flaky test
linodes/smoke-linode-landing-table.spec.ts • 1 flaky test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
@carrillo-erik not sure what you are trying to do with passing |
packages/manager/src/components/TypeToConfirmDialog/TypeToConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! needs some cleanup (will review in the browser when done)
Also, don't hesitate to add a comment why you are using a flex order because of the renderProps
packages/manager/src/components/TypeToConfirmDialog/TypeToConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/TypeToConfirmDialog/TypeToConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/TypeToConfirmDialog/TypeToConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
packages/manager/src/components/TypeToConfirmDialog/TypeToConfirmDialog.tsx
Outdated
Show resolved
Hide resolved
...c/features/Databases/DatabaseDetail/DatabaseSettings/DatabaseSettingsDeleteClusterDialog.tsx
Show resolved
Hide resolved
...es/manager/src/features/Kubernetes/KubernetesClusterDetail/DeleteKubernetesClusterDialog.tsx
Outdated
Show resolved
Hide resolved
...es/manager/src/features/Databases/DatabaseDetail/DatabaseBackups/RestoreFromBackupDialog.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you checkout the PR and run yarn
, then push the changes. The yarn.lock
is out of date
@carrillo-erik There has come together really nice. I think this component will benefit a ton from a storybook page. See https://github.com/linode/manager/tree/develop/packages/manager/src/components/Button as to how we did the JSDocs and stories file. Implementation looks good apart from this |
@bnussman-akamai I had pushed some changes to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality of all improved components looks good. Approved pending suggestions from @jaalah-akamai @bnussman-akamai.
Nice work and thanks for bearing with the review changes!
Sounds good @carrillo-erik, still before you merge, just run |
I had some merge conflicts with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
Description 📝
Refactor components to standardize type-to-confirm implementation using the
TypeToConfirmDialog
component.Major Changes 🔄
types
in theEntityInfo
interface:Database
,Kubernetes
,AccountSetting
.subType
property in theEntityInfo
interface:Backup
,Cluster
,ObjectStorage
,CloseAccount
.How to test 🧪