Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for self serve betas endpoints #9386

Merged
merged 10 commits into from
Jul 20, 2023

Conversation

CodyFinn-Akamai
Copy link
Contributor

Description 📝

Adds support for the self serve beta endpoints by:

Major Changes 🔄

List highlighting major changes

  • Adding endpoint wrapper functions in api-v4 package
  • Adding factories for betas and account betas
  • Adding server handlers for betas and account betas endpoints
  • Adding queries for betas and account betas

How to test 🧪

  1. Ensure the queries, factories, server handlers, and other changes match style guides

@bnussman-akamai bnussman-akamai added @linode/api-v4 Changes are made to the @linode/api-v4 package Ready for Review Missing Changeset labels Jul 11, 2023
@cypress
Copy link

cypress bot commented Jul 11, 2023

1 flaky tests on run #4873 ↗︎

0 181 3 0 Flakiness 1

Details:

Update packages/manager/.changeset/pr-9386-added-1689191860871.md
Project: Cloud Manager E2E Commit: 2721659cd2
Status: Passed Duration: 15:40 💡
Started: Jul 13, 2023 4:33 PM Ended: Jul 13, 2023 4:49 PM
Flakiness  cypress/e2e/core/objectStorage/object-storage-errors.spec.ts • 1 flaky test

View Output Video

Test Artifacts
object storage failure paths > shows error upon object upload failure Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jaalah-akamai
Copy link
Contributor

@CodyFinn-Akamai looks good! Just run yarn changeset and add two separate changesets for each package you touched

Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, made some comments for cleanup and to bring things in line with our current RQ patterns

packages/api-v4/.changeset/pr-9386-added-1689191794116.md Outdated Show resolved Hide resolved
packages/api-v4/src/index.ts Show resolved Hide resolved
packages/manager/.changeset/pr-9386-added-1689191860871.md Outdated Show resolved Hide resolved
packages/manager/src/factories/index.ts Show resolved Hide resolved
packages/api-v4/src/betas/types.ts Show resolved Hide resolved
packages/manager/src/queries/accountBetas.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/accountBetas.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/accountBetas.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/accountBetas.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/accountBetas.ts Outdated Show resolved Hide resolved
CodyFinn-Akamai and others added 7 commits July 13, 2023 14:19
Adds support for the self serve beta endpoints by:
  * Adding endpoint wrapper functions in api-v4 package
  * Adding factories for betas and account betas
  * Adding server handlers for betas and account betas endpoints
  * Adding queries for betas and account betas
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
@jaalah-akamai
Copy link
Contributor

@CodyFinn-Akamai this is looking good, there's a few pending comments from @dwiley-akamai remaining, otherwise GTG!

@bnussman-akamai bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Jul 18, 2023
Copy link
Contributor

@dwiley-akamai dwiley-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two other minor comments but this is good to go aside from those

packages/api-v4/src/account/betas.ts Outdated Show resolved Hide resolved
packages/manager/src/queries/betas.ts Outdated Show resolved Hide resolved
@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jul 18, 2023
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>
@CodyFinn-Akamai CodyFinn-Akamai merged commit 19ecd06 into linode:develop Jul 20, 2023
@CodyFinn-Akamai CodyFinn-Akamai deleted the self-serve-beta-api branch July 20, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! @linode/api-v4 Changes are made to the @linode/api-v4 package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants