feat: [M3-6759] - Handle VPC Account Grants / Permissions / Capabilities #9585

coliu-akamai · 2023-08-22T20:18:26Z

Description 📝

Add VPC grants, permissions, and capabilities to determine VPC usage

Major Changes 🔄

add VPC related grants to User Permissions page
add isFeatureEnabledFunctionality

Preview 📷

User Permissions:

no permissions:

Before	After

How to test 🧪

Test that user permissions ^ show up (either on MSW or possibly even dev account?)
Test if you can see any VPC pages while not on MSW (will need to have the relevant capability)
try to test editing a VPC when it is read_only (may need to add another user to change their permissions)
Try creating a vpc on an account that does not have the global permissions

dwiley-akamai

@coliu-akamai you can get a read-only VPC by creating a restricted user (if you don't have one already), and then from the main account, going to Users & Grants > User Permissions for the restricted user and marking that VPC as read-only for them. Then log in as the restricted user and confirm they can't edit anything for that VPC

packages/manager/.changeset/pr-9585-upcoming-features-1692736112038.md

packages/manager/src/features/Users/UserPermissions.tsx

packages/api-v4/.changeset/pr-9585-changed-1692736077405.md

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

…12038.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

coliu-akamai · 2023-08-23T18:35:04Z

thanks @dwiley-akamai, that worked!

dwiley-akamai

Looks good so far -- we'll want to have the isFeatureEnabled() logic in MainContent.tsx, AddNewMenu.tsx, and PrimaryNav.tsx too.

Also, VPCs show up on the landing page even if a restricted user's VPC permissions are set to "None" -- I think that may be an API bug since I tried from the command line and observed a similar result

coliu-akamai · 2023-08-25T18:51:18Z

thanks @dwiley-akamai, just added for those files! Will also make sure to stay up to date on your post about the potential bug

packages/manager/src/features/VPC/VPCLanding/VPCEditDrawer.tsx

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

dwiley-akamai

LGTM, just have to merge in the latest develop and resolve the conflicts 🚢

packages/manager/src/features/Linodes/index.tsx

dwiley-akamai

Didn't realize my review got dismissed earlier in the week 😅

dwiley-akamai · 2023-09-01T21:14:21Z

packages/manager/src/features/OneClickApps/oneClickApps.ts

Hmm, same thing happened on the Subnets PR with this file being pulled in somehow 🤔

Wondering if it's a prettier or eslint thing? Gonna try to get rid of the change

edit: yeah prettier moves the line down, then eslint doesn't let me commit without changes. I could add --no-verify to bypass, but since prettier will probably keep on moving the line back down anyway, I think it's fine to keep the changes

coliu-akamai · 2023-09-01T21:21:18Z

@dwiley-akamai sorry that was actually me -- I'd rerequested a review for the grant related changes I'd made for the VPC column in the linodes landing table, but since we undid that change, the review request turned out to be unnecessary 😅

hana-akamai

LGTM other than the "None" issue that Dajahi mentioned!

coliu-akamai · 2023-09-05T12:16:14Z

@hana-linode ty Hana! VPCs with permissions set to none will still show up due to API design, so we're treating them as read_only and have added in explanatory comment for this. gonna merge this! 🎉

…ies (linode#9585) * add vpc grant and permissions * yarn changeset * Update packages/api-v4/.changeset/pr-9585-changed-1692736077405.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * Update packages/manager/.changeset/pr-9585-upcoming-features-1692736112038.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * fix unresolved merge conflict issues * update vpc global grant text * add missing files * Update packages/manager/src/features/VPC/VPCLanding/VPCEditDrawer.tsx Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * add comment to explain VPC permissions --------- Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

…ies (#9585) * add vpc grant and permissions * yarn changeset * Update packages/api-v4/.changeset/pr-9585-changed-1692736077405.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * Update packages/manager/.changeset/pr-9585-upcoming-features-1692736112038.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * fix unresolved merge conflict issues * update vpc global grant text * add missing files * Update packages/manager/src/features/VPC/VPCLanding/VPCEditDrawer.tsx Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com> * add comment to explain VPC permissions --------- Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

add vpc grant and permissions

64e87f3

coliu-akamai self-assigned this Aug 22, 2023

coliu-akamai added the VPC Relating to VPC project label Aug 22, 2023

yarn changeset

c3251e6

coliu-akamai marked this pull request as ready for review August 22, 2023 20:33

bnussman-akamai added the Ready for Review label Aug 22, 2023

dwiley-akamai reviewed Aug 23, 2023

View reviewed changes

packages/manager/.changeset/pr-9585-upcoming-features-1692736112038.md Outdated Show resolved Hide resolved

packages/manager/src/features/Users/UserPermissions.tsx Outdated Show resolved Hide resolved

packages/api-v4/.changeset/pr-9585-changed-1692736077405.md Outdated Show resolved Hide resolved

coliu-akamai and others added 2 commits August 23, 2023 14:20

Update packages/api-v4/.changeset/pr-9585-changed-1692736077405.md

cd12385

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

Update packages/manager/.changeset/pr-9585-upcoming-features-16927361…

9854434

…12038.md Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

coliu-akamai force-pushed the feat-m3-6759 branch from 0175be1 to 9854434 Compare August 23, 2023 18:55

coliu-akamai added 3 commits August 23, 2023 14:56

Merge branch 'develop' into feat-m3-6759

2a60444

fix unresolved merge conflict issues

e973566

update vpc global grant text

da7f8fb

coliu-akamai added the @linode/api-v4 Changes are made to the @linode/api-v4 package label Aug 24, 2023

dwiley-akamai reviewed Aug 25, 2023

View reviewed changes

coliu-akamai added 2 commits August 25, 2023 14:36

add missing files

6cba1a8

merge conflict

f189b21

dwiley-akamai reviewed Aug 28, 2023

View reviewed changes

packages/manager/src/features/VPC/VPCLanding/VPCEditDrawer.tsx Outdated Show resolved Hide resolved

coliu-akamai and others added 2 commits August 28, 2023 12:38

Update packages/manager/src/features/VPC/VPCLanding/VPCEditDrawer.tsx

64df700

Co-authored-by: Dajahi Wiley <114682940+dwiley-akamai@users.noreply.github.com>

add comment to explain VPC permissions

f2cd240

dwiley-akamai approved these changes Aug 29, 2023

View reviewed changes

bnussman-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Aug 29, 2023

coliu-akamai added 2 commits August 30, 2023 12:27

Merge branch 'develop' into feat-m3-6759

2653fbf

Merge branch 'develop' into feat-m3-6759

b6f61a4

coliu-akamai requested a review from dwiley-akamai August 30, 2023 21:53

bnussman-akamai added Ready for Review and removed Add'tl Approval Needed Waiting on another approval! labels Aug 30, 2023

coliu-akamai force-pushed the feat-m3-6759 branch from 48bec66 to b6f61a4 Compare August 30, 2023 22:07

coliu-akamai commented Aug 30, 2023

View reviewed changes

packages/manager/src/features/Linodes/index.tsx Outdated Show resolved Hide resolved

coliu-akamai force-pushed the feat-m3-6759 branch from 3eca80d to b6f61a4 Compare September 1, 2023 17:15

Merge branch 'develop' into feat-m3-6759

6630110

coliu-akamai requested a review from hana-akamai September 1, 2023 17:16

dwiley-akamai approved these changes Sep 1, 2023

View reviewed changes

hana-akamai approved these changes Sep 1, 2023

View reviewed changes

coliu-akamai merged commit 0ba597b into linode:develop Sep 5, 2023

This was referenced Sep 15, 2023

Release v1.102.0 - release → staging #9686

Merged

Release v1.102.0 - staging → master #9695

Merged

coliu-akamai deleted the feat-m3-6759 branch September 26, 2023 19:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: [M3-6759] - Handle VPC Account Grants / Permissions / Capabilities #9585

feat: [M3-6759] - Handle VPC Account Grants / Permissions / Capabilities #9585

coliu-akamai commented Aug 22, 2023 •

edited

Loading

dwiley-akamai left a comment

coliu-akamai commented Aug 23, 2023

dwiley-akamai left a comment •

edited

Loading

coliu-akamai commented Aug 25, 2023

dwiley-akamai left a comment

dwiley-akamai left a comment

dwiley-akamai Sep 1, 2023

coliu-akamai Sep 1, 2023 •

edited

Loading

coliu-akamai commented Sep 1, 2023

hana-akamai left a comment

coliu-akamai commented Sep 5, 2023

feat: [M3-6759] - Handle VPC Account Grants / Permissions / Capabilities #9585

feat: [M3-6759] - Handle VPC Account Grants / Permissions / Capabilities #9585

Conversation

coliu-akamai commented Aug 22, 2023 • edited Loading

Description 📝

Major Changes 🔄

Preview 📷

How to test 🧪

dwiley-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai commented Aug 23, 2023

dwiley-akamai left a comment • edited Loading

Choose a reason for hiding this comment

coliu-akamai commented Aug 25, 2023

dwiley-akamai left a comment

Choose a reason for hiding this comment

dwiley-akamai left a comment

Choose a reason for hiding this comment

dwiley-akamai Sep 1, 2023

Choose a reason for hiding this comment

coliu-akamai Sep 1, 2023 • edited Loading

Choose a reason for hiding this comment

coliu-akamai commented Sep 1, 2023

hana-akamai left a comment

Choose a reason for hiding this comment

coliu-akamai commented Sep 5, 2023

coliu-akamai commented Aug 22, 2023 •

edited

Loading

dwiley-akamai left a comment •

edited

Loading

coliu-akamai Sep 1, 2023 •

edited

Loading