-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [M3-7029] - Add AGLB Certificate Create Drawer #9616
feat: [M3-7029] - Add AGLB Certificate Create Drawer #9616
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great π
Is there any type of additional validation we should run on those fields? Not sure if there's an expected shape for either
...nager/src/features/LoadBalancers/LoadBalancerDetail/Certificates/CreateCertificateDrawer.tsx
Show resolved
Hide resolved
<TextField | ||
errorText={errorMap.certificate} | ||
label="TLS Certificate" | ||
labelTooltipText="TODO" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure we have this tracked to complete in the future?
Description π
Preview π·
How to test π§ͺ
http://localhost:3000/loadbalancers/1/certificates
with the MSW on and try to upload a certificate (you can use fake values)