Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [M3-6749] - Subnet delete dialog #9640

Merged
merged 19 commits into from
Sep 12, 2023
Merged

feat: [M3-6749] - Subnet delete dialog #9640

merged 19 commits into from
Sep 12, 2023

Conversation

coliu-akamai
Copy link
Contributor

@coliu-akamai coliu-akamai commented Sep 6, 2023 •
edited
Loading

Description 📝

  • add subnet delete dialog to enable deleting of subnets

Preview 📷

Delete disabled on action menu:
image

Subnet Delete Dialog:
image

(tooltip icon color is off in this video recording again -- the color kinda just changes randomly 😭 )
https://github.com/linode/manager/assets/139280159/471dc77b-1975-4b08-bdaa-621df7023022

How to test 🧪

yarn test SubnetDeleteDialog.test.tsx
yarn test VPCSubnetsTable.test.tsx
yarn cy:run -s "cypress/e2e/core/vpc/vpc-details-page.spec.ts"

Navigate to a VPC's detail page and:

  • Verify that you cannot delete subnets that have linodes assigned to them
  • Verify that you can delete subnets that have no linodes assigned to them

@coliu-akamai coliu-akamai added the VPC Relating to VPC project label Sep 6, 2023
@coliu-akamai coliu-akamai self-assigned this Sep 6, 2023
@coliu-akamai coliu-akamai marked this pull request as ready for review September 7, 2023 18:24
@jdamore-linode jdamore-linode self-requested a review September 7, 2023 21:34
coliu-akamai and others added 2 commits September 8, 2023 11:52
@coliu-akamai @hana-akamai
Update packages/manager/src/features/VPCs/VPCDetail/SubnetActionMenu.tsx
9bf4afa 
Co-authored-by: Hana Xu <115299789+hana-linode@users.noreply.github.com>
@coliu-akamai
feedback
59a67e7
hana-akamai
hana-akamai approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🚀

@coliu-akamai coliu-akamai added Add'tl Approval Needed Waiting on another approval! and removed Ready for Review labels Sep 11, 2023
jdamore-linode
jdamore-linode approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@jdamore-linode jdamore-linode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @coliu-akamai!

@coliu-akamai coliu-akamai mentioned this pull request Sep 11, 2023
Merged
@coliu-akamai coliu-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 11, 2023
@hana-akamai hana-akamai mentioned this pull request Sep 12, 2023
Merged
@coliu-akamai
Copy link
Contributor Author

Merging as integration test failures are unrelated to this PR!

@coliu-akamai coliu-akamai merged commit 02d0a7b into linode:develop Sep 12, 2023
11 checks passed
This was referenced Sep 15, 2023
Merged
Merged
@coliu-akamai coliu-akamai deleted the feat-m3-6749 branch September 26, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hana-akamai hana-akamai hana-akamai approved these changes

@jdamore-linode jdamore-linode jdamore-linode approved these changes

Assignees

@coliu-akamai coliu-akamai

Labels
Approved Multiple approvals and ready to merge! VPC Relating to VPC project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coliu-akamai @jdamore-linode @hana-akamai