Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [M3-7099] - Metadata CLI command #9665

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

hana-akamai
Copy link
Contributor

@hana-akamai hana-akamai commented Sep 12, 2023

Description 📝

Fix metadata command when creating with the Linode CLI

Preview 📷

Before After
cli before cli after
cli command before cli command after

How to test 🧪

yarn test packages/manager/src/utilities/generate-cli.test.ts
  • Go to /linodes/create and fill out the create form with a cloud-init compatible image and a metadata compatible region (e.g. Washington, DC)
  • Enter some text in the User Data field of the Add User Data accordion
  • Click the Create Using Command Line button and click on the Linode CLI tab
  • Ensure that the metadata command is --metadata.user_data="<user_data>" instead of --metadata '{"user_data": "<user_data>"}'

@hana-akamai hana-akamai added Bug Fixes for regressions or bugs Project: Metadata Related to Metadata project labels Sep 12, 2023
@hana-akamai hana-akamai self-assigned this Sep 12, 2023
@hana-akamai hana-akamai marked this pull request as ready for review September 12, 2023 21:04
@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Sep 12, 2023
Copy link
Contributor

@abailly-akamai abailly-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mjac0bs mjac0bs added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Sep 13, 2023
@hana-akamai hana-akamai merged commit 2423f3f into linode:develop Sep 13, 2023
11 checks passed
@hana-akamai hana-akamai deleted the M3-7099-metadata-cli-command branch September 13, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Bug Fixes for regressions or bugs Project: Metadata Related to Metadata project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants