Fix: [M3-7116] Fix visual regression with Image Select option #9672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
commented
Sep 13, 2023
| @@ -27,6 +28,9 @@ const useStyles = makeStyles((theme: Theme) => ({ | |||
| color: 'white', | |||
| }, | |||
| root: { | |||
| '& *': { | |||
| lineHeight: '1.2em', | |||
| }, | |||
There was a problem hiding this comment.
This is the relevant change - in this case it only applies to the image select options, but we should keep an eye on other selects. Could not find similar regressions anywhere else during testing.
bnussman-akamai
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
This PR fixes a small regression with the image select options introduced by #9636
The defect is not in production yet, so the current fix should be evaluated as re-establishing parity with production in our development branch. Therefore we don't need a changeset.
Note: the PR also cleans up import/exports and
React.FCprops in files touched by the fix.Preview 📷
How to test 🧪