feat: [M3-7109] - Add AGLB Delete Route Dialog #9735
Conversation
bnussman-akamai
requested review from
jaalah-akamai and
abailly-akamai
and removed request for
a team
| <DeleteRouteDialog | ||
| loadbalancerId={Number(loadbalancerId)} | ||
| onClose={() => setIsDeleteDialogOpen(false)} | ||
| open={isDeleteDialogOpen} | ||
| route={selectedRoute} | ||
| /> |
There was a problem hiding this comment.
I tried conditionally rendering like how we discussed in cafe, but the animation close breaks so I'm using our normal pattern
There was a problem hiding this comment.
I actually do wonder if there is actual benefit in conditionally rendering the dialog, since the element isn't even mounted unless open is true. It sounds to me like performance issues would be more relevant when mounting a Dialog with a big tree (maybe like the Linode Resize dialog for instance). The docs mention a keepMounted prop to that effect, but it sounds like the opposite of what we usually want to do. From what I could read, it's a case that should be supported by performance benchmarks to justify its usage (when it outside the scope of a micro optimisation).
| <DeleteRouteDialog | ||
| loadbalancerId={Number(loadbalancerId)} | ||
| onClose={() => setIsDeleteDialogOpen(false)} | ||
| open={isDeleteDialogOpen} | ||
| route={selectedRoute} | ||
| /> |
There was a problem hiding this comment.
I actually do wonder if there is actual benefit in conditionally rendering the dialog, since the element isn't even mounted unless open is true. It sounds to me like performance issues would be more relevant when mounting a Dialog with a big tree (maybe like the Linode Resize dialog for instance). The docs mention a keepMounted prop to that effect, but it sounds like the opposite of what we usually want to do. From what I could read, it's a case that should be supported by performance benchmarks to justify its usage (when it outside the scope of a micro optimisation).
Description 📝
Preview 📷
How to test 🧪
http://localhost:3000/loadbalancers/0/routesDELETE https://api.linode.com/v4beta/aglb/0/routes/24API call happens on deleteGET https://api.linode.com/v4beta/aglb/0/routes?page=1&page_size=25API call)