-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-7230] - Migrate NodeBalancer Node Mode Select TextField to Autocomplete #9754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like removing a Backend Node broke 🤔
Screen.Recording.2023-10-05.at.5.03.23.PM.mov
…from-textfield-to-autocomplete
@hana-linode Thank you! Fixed in eb9667a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the Mode
select still looks and works as expected and that remove still works 🎉
packages/manager/src/features/NodeBalancers/NodeBalancerConfigNode.tsx
Outdated
Show resolved
Hide resolved
…from-textfield-to-autocomplete
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bnussman-akamai! Confirmed that the autocomplete field works/looks as expected and that I can add/remove nodes. Also confirmed that I can actually save the config changes
Description 📝
Major Changes 🔄
Remove
button styles<TextField select>...</TextField>
with an<Autocomplete />
Preview 📷
How to test 🧪
Mode
Select