chore: Update vite and sanitize-html to update postcss for dependabot
#9767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnussman-akamai
added
the
Dependencies
bnussman-akamai
requested review from
jdamore-linode and
carrillo-erik
and removed request for
a team
jdamore-linode
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
Thank you @bnussman-akamai!
- Confirmed
postcssresolves to8.4.31inyarn.lock - Confirmed that Cloud builds via
yarn devand viayarn build - Confirmed that the Cypress tests build OK (didn't run the full suite, however)
- Poked around a bit in Cloud and Storybook and did not observe any issues
|
I didn't find any issues running the PR locally. |
carrillo-erik
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
Detailed Explanation
viteandsanitize-htmlso thatpostcssconsequently gets bumped to resolve https://github.com/linode/manager/security/dependabot/84. This works becauseviteandsanitize-htmlare the only two dependents onpostcssand updating both of them will result in us getting the desiredpostcssversionMajor Changes 🔄
viteto latestsanitize-html(and its types) to latest@vitejs/plugin-react-swcto latestHow to test 🧪
yarn.lock, postcss resolves to only version8.4.31or newer