-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: [M3-6273] - MUI v5 Migration - SRC > Features > Lish #9774
Conversation
import Glish from './Glish'; | ||
import Weblish from './Weblish'; | ||
|
||
const AUTH_POLLING_INTERVAL = 2000; | ||
|
||
const useStyles = makeStyles((theme: Theme) => ({ | ||
notFound: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was never used
}, | ||
color: '#f4f4f4 !important', | ||
}, | ||
progress: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has no effect whatsoever, so I removed since we're centering this anyways
@@ -11,7 +11,7 @@ const useStyles = makeStyles()((theme: Theme) => ({ | |||
}, | |||
'&:hover': { | |||
backgroundColor: theme.color.grey7, | |||
color: `${theme.palette.primary.main} !important`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Co-authored-by: Banks Nussman <115251059+bnussman-akamai@users.noreply.github.com>
Reproduced original state ✅ Ensured that:
|
Also, when you say: "Loading state is vertically centered", do you mean the loading circle progress icon is horizontally centered? I wouldn't consider it vertically centered (Since its closer to the top), but I do like how it looks now. I just wanted to confirm before checking it off. |
Good work so far! |
|
Still seems like there is too much spacing on the left hand side. Not sure if this is a problem that should be addressed in this PR or another. Or maybe its not a problem at all, thoughts? Screen.Recording.2023-10-11.at.9.47.06.AM.mov |
I think I misunderstood your concern - lets sync offline |
Description 📝
Refactored
Lish
as part of MUI v5 migrationChanges 🔄
CircleProgress.tsx
- Allowsx
to be passed in as propsReachTab.tsx
- Remove!important
that was causing styling issues withLish
tabsLish.tsx
- No need to import css files inuseEffect
, we can import normally.CircleProgress
when loadingFragment
and return null insteadStyled
api instead ofmakeStyles
Preview 📷
lish-cloud-dark.mp4
lish-local-dark.mp4
lish-cloud-light.mp4
lish-local-light.mp4
How to test 🧪
Prerequisites
Reproduction steps
Verification steps
isLoading
condition totrue
to testAs an Author I have considered 🤔
Check all that apply