Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix DBaaS tests after API update #9801

Merged

Conversation

jdamore-linode
Copy link
Contributor

Description 📝

This fixes the DBaaS tests by mocking the request to the DBaaS node types endpoint.

How to test 🧪

We can rely on the automated tests, but to run the tests locally you can use this command:

yarn cy:run -s "cypress/e2e/core/databases/create-database.spec.ts,cypress/e2e/core/databases/update-database.spec.ts,cypress/e2e/core/databases/delete-database.spec.ts"

@jdamore-linode jdamore-linode self-assigned this Oct 17, 2023
@jdamore-linode jdamore-linode requested a review from a team as a code owner October 17, 2023 12:49
@jdamore-linode jdamore-linode requested review from mjac0bs and hana-akamai and removed request for a team October 17, 2023 12:49
Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

🚀 Thanks, Joe! Looked good on a local run.

@mjac0bs mjac0bs added the Approved Multiple approvals and ready to merge! label Oct 17, 2023
Copy link
Contributor

@hana-akamai hana-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the tests passed locally 🎉

@jdamore-linode jdamore-linode merged commit 8b581a8 into linode:develop Oct 17, 2023
11 checks passed
abailly-akamai pushed a commit to abailly-akamai/manager that referenced this pull request Oct 17, 2023
* Add mock util and constants to support DBaaS node type mocking

* Fix DBaaS tests by mocking node types requests

* Added changeset: Fix DBaaS UI test failures stemming from API update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants